utils/pub/validator/name.dart - Issue 12042053: Get rid of unneeded Future.immediate() calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/validator/name.dart

Issue 12042053: Get rid of unneeded Future.immediate() calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/pub/validator/name.dart

diff --git a/utils/pub/validator/name.dart b/utils/pub/validator/name.dart

index 67e2da0257bc6bca4a76f96843f46fe741622506..eb1bc85034edc1b1295ab73049d598ed79c82120 100644

--- a/utils/pub/validator/name.dart

+++ b/utils/pub/validator/name.dart

@@ -48,7 +48,7 @@ class NameValidator extends Validator {

Future<List<String>> get _libraries {

var libDir = join(entrypoint.root.dir, "lib");

return dirExists(libDir).then((libDirExists) {

- if (!libDirExists) return new Future.immediate([]);

+ if (!libDirExists) return [];

return listDir(libDir, recursive: true);

}).then((files) {

return files