Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 12042015: Telemtry: fixes version detection for mobile and supports_tracing. (Closed)

Created:
7 years, 11 months ago by bulach
Modified:
7 years, 10 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Telemtry: fixes version detection for mobile and supports_tracing. BUG=170284 TEST=tools/telemetry/run_tests --browser=android-content-shell testGotTrace -vv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180681

Patch Set 1 #

Patch Set 2 : Rebased and fixed regexp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/telemetry/telemetry/browser_backend.py View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bulach
splitting a small bit from https://codereview.chromium.org/11931015/, ptal
7 years, 11 months ago (2013-01-21 19:29:04 UTC) #1
nduca
lgtm
7 years, 11 months ago (2013-01-22 22:13:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12042015/1
7 years, 11 months ago (2013-01-25 21:30:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12042015/1
7 years, 10 months ago (2013-02-04 11:29:58 UTC) #4
commit-bot: I haz the power
Failed to apply patch for tools/telemetry/telemetry/browser_backend.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-02-04 11:29:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12042015/21001
7 years, 10 months ago (2013-02-04 20:20:13 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-04 21:25:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12042015/21001
7 years, 10 months ago (2013-02-05 09:53:14 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-05 10:59:48 UTC) #9
Message was sent while issue was closed.
Change committed as 180681

Powered by Google App Engine
This is Rietveld 408576698