Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: tools/telemetry/telemetry/browser_backend.py

Issue 12042015: Telemtry: fixes version detection for mobile and supports_tracing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased and fixed regexp Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/browser_backend.py
diff --git a/tools/telemetry/telemetry/browser_backend.py b/tools/telemetry/telemetry/browser_backend.py
index 8b3051f5cad541bc52e39f3e5fd86d192625c732..7c7c68521fe502933bacbca04b5ae6643d4c400b 100644
--- a/tools/telemetry/telemetry/browser_backend.py
+++ b/tools/telemetry/telemetry/browser_backend.py
@@ -102,8 +102,9 @@ class BrowserBackend(object):
branch_number_match = re.search('Chrome/\d+\.\d+\.(\d+)\.\d+',
resp['Browser'])
else:
- branch_number_match = re.search('Chrome/\d+\.\d+\.(\d+)\.\d+ Safari',
- resp['User-Agent'])
+ branch_number_match = re.search(
+ 'Chrome/\d+\.\d+\.(\d+)\.\d+ (Mobile )?Safari',
+ resp['User-Agent'])
webkit_version_match = re.search('\((trunk)?\@(\d+)\)',
resp['WebKit-Version'])
@@ -140,7 +141,7 @@ class BrowserBackend(object):
@property
def supports_tracing(self):
- return True
+ return self.is_content_shell or self._chrome_branch_number >= 1385
def StartTracing(self):
if self._tracing_backend is None:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698