sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart - Issue 12042003: Move relational operators to the new interceptors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

Issue 12042003: Move relational operators to the new interceptors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart (revision 17334)

+++ sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart (working copy)

@@ -706,7 +706,7 @@

Range rightRange = ranges[relational.right];

Range leftRange = ranges[relational.left];

- if (relational is HEquals || relational is HIdentity) {

+ if (relational is HIdentity) {

handleEqualityCheck(relational);

} else if (operation.apply(leftRange, rightRange)) {

relational.block.rewrite(

@@ -829,7 +829,6 @@

var condition = branch.condition;

// TODO(ngeoffray): Handle complex conditions.

if (condition is !HRelational) return info.newUnboundRange();

- if (condition is HEquals) return info.newUnboundRange();

if (condition is HIdentity) return info.newUnboundRange();

HInstruction right = condition.right;

HInstruction left = condition.left;