Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

Issue 12042003: Move relational operators to the new interceptors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (revision 17334)
+++ sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (working copy)
@@ -270,8 +270,6 @@
String visitDivide(HDivide node) => handleBinaryArithmetic(node, '/');
- String visitEquals(HEquals node) => visitInvokeStatic(node);
-
String visitExit(HExit node) => "exit";
String visitFieldGet(HFieldGet node) {
@@ -293,11 +291,12 @@
return "Goto: (B${target.id})";
}
- String visitGreater(HGreater node) => visitInvokeStatic(node);
- String visitGreaterEqual(HGreaterEqual node) => visitInvokeStatic(node);
+ String visitGreater(HGreater node) => handleBinaryArithmetic(node, '>');
+ String visitGreaterEqual(HGreaterEqual node) {
+ handleBinaryArithmetic(node, '>=');
+ }
+ String visitIdentity(HIdentity node) => handleBinaryArithmetic(node, '===');
- String visitIdentity(HIdentity node) => visitInvokeStatic(node);
-
String visitIf(HIf node) {
HBasicBlock thenBlock = currentBlock.successors[0];
HBasicBlock elseBlock = currentBlock.successors[1];
@@ -384,8 +383,8 @@
node.inputs);
}
- String visitLess(HLess node) => visitInvokeStatic(node);
- String visitLessEqual(HLessEqual node) => visitInvokeStatic(node);
+ String visitLess(HLess node) => handleBinaryArithmetic(node, '<');
+ String visitLessEqual(HLessEqual node) => handleBinaryArithmetic(node, '<=');
String visitLiteralList(HLiteralList node) {
StringBuffer elementsString = new StringBuffer();

Powered by Google App Engine
This is Rietveld 408576698