Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1203943002: HTMLOptionElement constructor arguments default values are not per spec (Closed)

Created:
5 years, 6 months ago by shiva.jm
Modified:
5 years, 3 months ago
Reviewers:
pdr., philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

HTMLOptionElement constructor arguments default values are not per spec As per spec link: https://html.spec.whatwg.org/#the-option-element, default value for selected attribute is false. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197930

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M LayoutTests/fast/js/custom-constructors-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/js/script-tests/custom-constructors.js View 1 1 chunk +3 lines, -0 lines 1 comment Download
M Source/core/html/HTMLOptionElement.idl View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 36 (18 generated)
shiva.jm
pls have a look.
5 years, 6 months ago (2015-06-24 06:46:07 UTC) #2
philipj_slow
Thanks, this LGTM, but remove the text if some existing test covers it. If you ...
5 years, 6 months ago (2015-06-24 09:08:56 UTC) #3
shiva.jm
Updated the review comments. pls have a look. https://codereview.chromium.org/1203943002/diff/1/LayoutTests/fast/dom/HTMLOptionElement/option-constructor.html File LayoutTests/fast/dom/HTMLOptionElement/option-constructor.html (right): https://codereview.chromium.org/1203943002/diff/1/LayoutTests/fast/dom/HTMLOptionElement/option-constructor.html#newcode2 LayoutTests/fast/dom/HTMLOptionElement/option-constructor.html:2: <script ...
5 years, 6 months ago (2015-06-25 05:51:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203943002/20001
5 years, 6 months ago (2015-06-25 09:01:13 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-25 10:11:59 UTC) #22
shiva.jm
On 2015/06/24 09:08:56, philipj wrote: > Thanks, this LGTM, but remove the text if some ...
5 years, 6 months ago (2015-06-25 11:51:33 UTC) #23
Habib Virji
Apologise by mistake clicked on the closed button.
5 years, 6 months ago (2015-06-25 13:19:30 UTC) #24
Habib Virji
Apologise by mistake clicked on the closed button.
5 years, 6 months ago (2015-06-25 13:19:32 UTC) #25
philipj_slow
LGTM. Please reference a bug or remove the empty BUG= before sending to CQ. https://codereview.chromium.org/1203943002/diff/20001/LayoutTests/fast/js/script-tests/custom-constructors.js ...
5 years, 6 months ago (2015-06-26 14:28:38 UTC) #26
philipj_slow
(Also wrap description to 72 columns.)
5 years, 6 months ago (2015-06-26 14:28:55 UTC) #27
philipj_slow
(Also wrap description to 72 columns.)
5 years, 6 months ago (2015-06-26 14:28:57 UTC) #28
shiva.jm
On 2015/06/26 14:28:38, philipj wrote: > LGTM. Please reference a bug or remove the empty ...
5 years, 6 months ago (2015-06-26 15:49:04 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203943002/20001
5 years, 6 months ago (2015-06-26 15:49:38 UTC) #31
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=197930
5 years, 6 months ago (2015-06-26 17:01:11 UTC) #32
philipj_slow
In this CL you accidentally removed the first line from the description. I've made the ...
5 years, 5 months ago (2015-07-01 11:40:16 UTC) #33
shiva.jm
On 2015/07/01 11:40:16, philipj wrote: > In this CL you accidentally removed the first line ...
5 years, 5 months ago (2015-07-01 11:56:59 UTC) #34
philipj_slow
On 2015/07/01 11:56:59, shiva.jm wrote: > On 2015/07/01 11:40:16, philipj wrote: > > In this ...
5 years, 5 months ago (2015-07-01 14:43:59 UTC) #35
shiva.jm
5 years, 3 months ago (2015-09-24 04:18:36 UTC) #36
Message was sent while issue was closed.
On 2015/07/01 14:43:59, philipj wrote:
> On 2015/07/01 11:56:59, shiva.jm wrote:
> > On 2015/07/01 11:40:16, philipj wrote:
> > > In this CL you accidentally removed the first line from the description.
> I've
> > > made the same mistake, and it means that the resulting commit doesn't have
a
> > > good description.
> > 
> > I checked in the link:
> >
>
http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLOptionElement...,
> > description/Log Message is visible fine. is the link i am looking is
different
> > ?.
> 
> Oh, I wasn't paying attention, now I see what happened. The title was just
> wrapped to 72 columns (as I asked) and so it's split into two lines. No
worries.

These change was made to address FIX mes in HTML IDL files, these issue can be
associated to bug: https://code.google.com/p/chromium/issues/detail?id=460722.
may be its missed out in revision.

Powered by Google App Engine
This is Rietveld 408576698