LayoutTests/fast/js/script-tests/custom-constructors.js - Issue 1203943002: HTMLOptionElement constructor arguments default values are not per spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/js/script-tests/custom-constructors.js

Issue 1203943002: HTMLOptionElement constructor arguments default values are not per spec (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/js/script-tests/custom-constructors.js

diff --git a/LayoutTests/fast/js/script-tests/custom-constructors.js b/LayoutTests/fast/js/script-tests/custom-constructors.js

index ce5c42ff70c93a7c68d567489c2971fe9b97c470..e7c749ef3f1fe6ddf33a5c41d88fcc84a3426614 100644

--- a/LayoutTests/fast/js/script-tests/custom-constructors.js

+++ b/LayoutTests/fast/js/script-tests/custom-constructors.js

@@ -43,7 +43,10 @@ shouldBeEqualToString("new Option('somedata', 'somevalue').value", "somevalue");

shouldBeFalse("new Option().defaultSelected");

shouldBeFalse("new Option('somedata', 'somevalue').defaultSelected");

shouldBeFalse("new Option('somedata', 'somevalue', false).defaultSelected");

+shouldBeFalse("new Option('somedata', 'somevalue', false, false).defaultSelected");

philipj_slow 2015/06/26 14:28:38 I don't think testing that the |selected| argument

shouldBeTrue("new Option('somedata', 'somevalue', true).defaultSelected");

+shouldBeTrue("new Option('somedata', 'somevalue', true, false).defaultSelected");

+shouldBeTrue("new Option('somedata', 'somevalue', true, true).defaultSelected");

shouldBeFalse("new Option().selected");

shouldBeFalse("new Option('somedata', 'somevalue').selected");

« no previous file with comments | « LayoutTests/fast/js/custom-constructors-expected.txt ('k') | Source/core/html/HTMLOptionElement.idl » ('j') | no next file with comments »