Add support for content shell builder and extra layout tests parameters

Add support for content shell builder and extra layout tests parameters

BUG=156214
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178378

[jochen (gone - plz use gerrit), 2013-01-23 10:39:39]

plz review

[Isaac (away), 2013-01-23 11:26:50]

Comments inline.

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:206: for flag in
'test_results_server', 'driver_name', 'additional_drt_flag':
This loop seems weird.  Won't it append multiple --test-results-server args?

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:207: if
options.factory_properties.has_key(flag):
nit: factory_properties is a dict.  Is it sufficient to use 'if flag in
options.factory_props' ?

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:211: for f in
options.factory_properties.get('additional_expectations_files', []):
DIdn't know json.loads (the factory_props parser) produced list objects, but if
it works it looks right.

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:212:
cmd_args.append('--additional-expectations-file')
nit: use extend w/ both args.

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_run...
File build/android/buildbot/bb_run_bot.py (right):

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_run...
build/android/buildbot/bb_run_bot.py:106: B('webkit-contentshell-webkit',
compile_step, T(['webkit_layout']), None),
how about "webkit-latest-contentshell"?

[jochen (gone - plz use gerrit), 2013-01-23 12:08:13]

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:206: for flag in
'test_results_server', 'driver_name', 'additional_drt_flag':
On 2013/01/23 11:26:50, Isaac wrote:
> This loop seems weird.  Won't it append multiple --test-results-server args?

uups, fixed

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:207: if
options.factory_properties.has_key(flag):
On 2013/01/23 11:26:50, Isaac wrote:
> nit: factory_properties is a dict.  Is it sufficient to use 'if flag in
> options.factory_props' ?

Done.

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:211: for f in
options.factory_properties.get('additional_expectations_files', []):
On 2013/01/23 11:26:50, Isaac wrote:
> DIdn't know json.loads (the factory_props parser) produced list objects, but
if
> it works it looks right.
The code is the same in scripts/master/factory/chromium_commands.py

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_dev...
build/android/buildbot/bb_device_steps.py:212:
cmd_args.append('--additional-expectations-file')
On 2013/01/23 11:26:50, Isaac wrote:
> nit: use extend w/ both args.

Done.

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_run...
File build/android/buildbot/bb_run_bot.py (right):

https://codereview.chromium.org/12039036/diff/1/build/android/buildbot/bb_run...
build/android/buildbot/bb_run_bot.py:106: B('webkit-contentshell-webkit',
compile_step, T(['webkit_layout']), None),
On 2013/01/23 11:26:50, Isaac wrote:
> how about "webkit-latest-contentshell"?

Done.

[Isaac (away), 2013-01-23 17:45:50]

LGTM, thanks!

[commit-bot: I haz the power, 2013-01-23 17:47:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/12039036/2002