Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2897)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 12039036: Add support for content shell builder and extra layout tests parameters (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/buildbot/bb_run_bot.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index d512a855e8b229b5cf4fdfc88c3ab2be850bc956..9239ef542e6970115289f76b0610809efd6abc42 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -187,23 +187,32 @@ def RunWebkitLint(target):
def RunWebkitLayoutTests(options):
"""Run layout tests on an actual device."""
buildbot_report.PrintNamedStep('webkit_tests')
- RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py',
- '--no-show-results',
- '--no-new-test-results',
- '--full-results-html',
- '--clobber-old-results',
- '--exit-after-n-failures', '5000',
- '--exit-after-n-crashes-or-timeouts', '100',
- '--debug-rwt-logging',
- '--results-directory', '..layout-test-results',
- '--target', options.target,
- '--builder-name', options.build_properties.get('buildername', ''),
- '--build-number', options.build_properties.get('buildnumber', ''),
- '--master-name', options.build_properties.get('mastername', ''),
- '--build-name', options.build_properties.get('buildername', ''),
- '--platform=chromium-android',
- '--test-results-server',
- options.factory_properties.get('test_results_server', '')])
+ cmd_args = [
+ '--no-show-results',
+ '--no-new-test-results',
+ '--full-results-html',
+ '--clobber-old-results',
+ '--exit-after-n-failures', '5000',
+ '--exit-after-n-crashes-or-timeouts', '100',
+ '--debug-rwt-logging',
+ '--results-directory', '..layout-test-results',
+ '--target', options.target,
+ '--builder-name', options.build_properties.get('buildername', ''),
+ '--build-number', options.build_properties.get('buildnumber', ''),
+ '--master-name', options.build_properties.get('mastername', ''),
+ '--build-name', options.build_properties.get('buildername', ''),
+ '--platform=chromium-android']
+
+ for flag in 'test_results_server', 'driver_name', 'additional_drt_flag':
+ if flag in options.factory_properties:
+ cmd_args.extend(['--%s' % flag.replace('_', '-'),
+ options.factory_properties.get(flag)])
+
+ for f in options.factory_properties.get('additional_expectations_files', []):
+ cmd_args.extend(['--additional-expectations-file',
+ os.path.join(CHROME_SRC, *f)])
+
+ RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py'] + cmd_args)
def MainTestWrapper(options):
« no previous file with comments | « no previous file | build/android/buildbot/bb_run_bot.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698