Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 12039021: Merge 140057 (Closed)

Created:
7 years, 11 months ago by Stephen White
Modified:
7 years, 11 months ago
Reviewers:
sugoi1
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 140057 > imageSmoothingEnabled frequent, unpredictable crashes > https://bugs.webkit.org/show_bug.cgi?id=107161 > > Patch by Alexis Hetu <sugoi@chromium.org>; on 2013-01-17 > Reviewed by Stephen White. > > Source/WebCore: > > Added a NULL pointer check to fix a crash. > > Test: fast/canvas/canvas-imageSmoothingEnabled-zero-size.html > > * html/canvas/CanvasRenderingContext2D.cpp: > (WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled): > > LayoutTests: > > Added a layout test for setting image smoothing enabled on a 0 sized > canvas. > > * fast/canvas/canvas-imageSmoothingEnabled-zero-size-expected.txt: Added. > * fast/canvas/canvas-imageSmoothingEnabled-zero-size.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --1 lines) Patch
A + LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-zero-size.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/canvas/canvas-imageSmoothingEnabled-zero-size-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Stephen White
7 years, 11 months ago (2013-01-22 19:22:52 UTC) #1
sugoi
7 years, 11 months ago (2013-01-22 20:42:09 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698