Issue 120383002: HTMLCollection should not inherit NodeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 120383002: HTMLCollection should not inherit NodeList (Closed)

Created:
7 years ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
esprehn, dominicc (has gone to gerrit), abarth-chromium

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

HTMLCollection should not inherit NodeList HTMLCollection should not inherit NodeList. Those types are unrelated in DOM so having one inherit the other on native side was confusing. It also led to: - HTMLCollection redefining isLiveNodeList() which was virtual in NodeList - HTMLCollection::item() / HTMLCollection::length() were needlessly virtual, which is bad for performance R=abarth, esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164383

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -31 lines)			Patch
M	Source/core/dom/LiveNodeList.h	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	Source/core/html/HTMLCollection.h	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/120383002/1

6 years, 11 months ago (2013-12-30 17:56:07 UTC) #3

Message was sent while issue was closed.

Change committed as 164383

Expand Messages | Collapse Messages