Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: Source/core/html/HTMLCollection.h

Issue 120383002: HTMLCollection should not inherit NodeList (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLCollection.h
diff --git a/Source/core/html/HTMLCollection.h b/Source/core/html/HTMLCollection.h
index 967b247db4d0fd2c0aad17b994c25ded844f06d7..091201667a2175fb55abd206b3095f9c80c8071f 100644
--- a/Source/core/html/HTMLCollection.h
+++ b/Source/core/html/HTMLCollection.h
@@ -31,7 +31,7 @@
namespace WebCore {
-class HTMLCollection : public LiveNodeListBase {
+class HTMLCollection : public ScriptWrappable, public RefCounted<HTMLCollection>, public LiveNodeListBase {
public:
static PassRefPtr<HTMLCollection> create(Node* base, CollectionType);
virtual ~HTMLCollection();
@@ -40,7 +40,6 @@ public:
virtual Node* namedItem(const AtomicString& name) const;
// Non-DOM API
- virtual bool hasNamedItem(const AtomicString& name) const;
void namedItems(const AtomicString& name, Vector<RefPtr<Node> >&) const;
bool isEmpty() const
{
@@ -79,8 +78,6 @@ private:
bool checkForNameMatch(Element*, bool checkName, const AtomicString& name) const;
Element* traverseNextElement(unsigned& offsetInArray, Element& previous, ContainerNode* root) const;
- virtual bool isLiveNodeList() const OVERRIDE { ASSERT_NOT_REACHED(); return true; }
-
static void append(NodeCacheMap&, const AtomicString&, Element*);
mutable NodeCacheMap m_idCache;
« no previous file with comments | « Source/core/dom/LiveNodeList.h ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698