Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/gl/gl_context.cc

Issue 12038095: Android webview fix gpu crashes after destroy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/common/gpu/image_transport_surface_android.cc ('K') | « content/common/gpu/image_transport_surface_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_context.cc
diff --git a/ui/gl/gl_context.cc b/ui/gl/gl_context.cc
index a6e67da31b69e6ea2f02bf0a7af0ae64f1301bb2..2df03c28fced9ca7ce7fa57ca80d820bc92d7efd 100644
--- a/ui/gl/gl_context.cc
+++ b/ui/gl/gl_context.cc
@@ -121,8 +121,8 @@ bool GLContext::MakeVirtuallyCurrent(
}
void GLContext::OnDestroyVirtualContext(GLContext* virtual_context) {
- DCHECK(virtual_gl_api_);
- virtual_gl_api_->OnDestroyVirtualContext(virtual_context);
+ if (virtual_gl_api_)
+ virtual_gl_api_->OnDestroyVirtualContext(virtual_context);
no sievers 2013/01/25 20:24:41 This change looks correct for where GLContextVirtu
boliu 2013/01/25 21:27:02 Crash stack for this is in the bug.
}
void GLContext::SetRealGLApi() {
« content/common/gpu/image_transport_surface_android.cc ('K') | « content/common/gpu/image_transport_surface_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698