Android webview fix gpu crashes after destroy

content/common/gpu/image_transport_surface_android.cc

Index: content/common/gpu/image_transport_surface_android.cc
diff --git a/content/common/gpu/image_transport_surface_android.cc b/content/common/gpu/image_transport_surface_android.cc
index f476f7554c472a8589fe08616dfd27da0ee4d72c..deda2fcd0bfccd666e18d832b87a5426c74c709d 100644
--- a/content/common/gpu/image_transport_surface_android.cc
+++ b/content/common/gpu/image_transport_surface_android.cc
@@ -23,7 +23,8 @@ scoped_refptr<gfx::GLSurface> ImageTransportSurface::CreateSurface(
     DCHECK(GpuSurfaceLookup::GetInstance());
     ANativeWindow* window = GpuSurfaceLookup::GetInstance()->GetNativeWidget(
         stub->surface_id());
-    DCHECK(window);
+    if (!window)
+      return NULL;  // May happen after AwContents.destroy

[no sievers, 2013/01/25 20:24:41]

Usually I'd think that this implies a bug (such as a race) in the code.
Does this happen because you quickly create and destroy a compositor (removing
the surface from the tracker) before we get a chance to create the context on
the gpu thread?

Wouldn't surface->Initialize() below fail if window was NULL?

The change is fine with me though. But you might want to add a LOG(ERROR) (maybe
also for the next return).

[boliu, 2013/01/25 21:27:02]

Yes, the process is create awcontents->load about:blank->destroy, I think the
whole thing is pretty fast.
So I'm seeing a null pointer exception in Initialize that's freaking me out
since I basically added DCHECKs for everything before where the crash is and
nothing appeared null. I'll post the stack crash in the bug if I can't figure it
out.
btw, LOG(ERROR) is equivalent to CHECK(false), did you really want to crash in
production too?

     surface = new gfx::NativeViewGLSurfaceEGL(false, window);
     if (!surface.get() || !surface->Initialize())
       return NULL;