Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4511)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
index e12850114ae2df565c06836fd80175b487567e22..ee7f635267bf17e42e8631cae019acbc9d8a8201 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
+++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h
@@ -11,8 +11,6 @@
#include "base/basictypes.h"
#include "chrome/common/extensions/api/bookmarks.h"
-class ChromeBookmarkClient;
-
namespace bookmarks {
class BookmarkModel;
class BookmarkNode;
@@ -24,25 +22,24 @@ namespace bookmark_api_helpers {
// The returned value is owned by the caller.
api::bookmarks::BookmarkTreeNode* GetBookmarkTreeNode(
- ChromeBookmarkClient* client,
+ bookmarks::BookmarkModel* model,
const bookmarks::BookmarkNode* node,
bool recurse,
bool only_folders);
// Add a JSON representation of |node| to the JSON |nodes|.
-void AddNode(ChromeBookmarkClient* client,
+void AddNode(bookmarks::BookmarkModel* model,
const bookmarks::BookmarkNode* node,
std::vector<linked_ptr<api::bookmarks::BookmarkTreeNode> >* nodes,
bool recurse);
-void AddNodeFoldersOnly(ChromeBookmarkClient* client,
+void AddNodeFoldersOnly(bookmarks::BookmarkModel* client,
const bookmarks::BookmarkNode* node,
std::vector<linked_ptr<
api::bookmarks::BookmarkTreeNode> >* nodes,
bool recurse);
bool RemoveNode(bookmarks::BookmarkModel* model,
- ChromeBookmarkClient* client,
int64 id,
bool recursive,
std::string* error);

Powered by Google App Engine
This is Rietveld 408576698