Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc

Issue 1203713002: Limit access to ChromeBookmarkClient to bookmarks code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_bookmark_client
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc
index 4e0fa043cdadc40959c5a6a818bd9b124cc40a58..8b73a7c52b8df8f867a6194c56e49bc1140e4cda 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc
@@ -9,7 +9,6 @@
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/bookmarks/chrome_bookmark_client.h"
#include "chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h"
#include "chrome/common/extensions/api/bookmarks.h"
#include "components/bookmarks/browser/bookmark_model.h"
@@ -27,13 +26,13 @@ namespace bookmark_api_helpers {
namespace {
-void AddNodeHelper(ChromeBookmarkClient* client,
+void AddNodeHelper(BookmarkModel* model,
const BookmarkNode* node,
std::vector<linked_ptr<BookmarkTreeNode> >* nodes,
bool recurse,
bool only_folders) {
if (node->IsVisible()) {
- linked_ptr<BookmarkTreeNode> new_node(GetBookmarkTreeNode(client,
+ linked_ptr<BookmarkTreeNode> new_node(GetBookmarkTreeNode(model,
node,
recurse,
only_folders));
@@ -43,7 +42,7 @@ void AddNodeHelper(ChromeBookmarkClient* client,
} // namespace
-BookmarkTreeNode* GetBookmarkTreeNode(ChromeBookmarkClient* client,
+BookmarkTreeNode* GetBookmarkTreeNode(BookmarkModel* model,
const BookmarkNode* node,
bool recurse,
bool only_folders) {
@@ -76,8 +75,8 @@ BookmarkTreeNode* GetBookmarkTreeNode(ChromeBookmarkClient* client,
new double(floor(node->date_added().ToDoubleT() * 1000)));
}
- if (bookmarks::IsDescendantOf(node, client->managed_node()) ||
- bookmarks::IsDescendantOf(node, client->supervised_node())) {
+ if (bookmarks::IsDescendantOf(node, model->managed_node()) ||
+ bookmarks::IsDescendantOf(node, model->supervised_node())) {
bookmark_tree_node->unmodifiable =
api::bookmarks::BOOKMARK_TREE_NODE_UNMODIFIABLE_MANAGED;
}
@@ -88,7 +87,7 @@ BookmarkTreeNode* GetBookmarkTreeNode(ChromeBookmarkClient* client,
const BookmarkNode* child = node->GetChild(i);
if (child->IsVisible() && (!only_folders || child->is_folder())) {
linked_ptr<BookmarkTreeNode> child_node(
- GetBookmarkTreeNode(client, child, true, only_folders));
+ GetBookmarkTreeNode(model, child, true, only_folders));
children.push_back(child_node);
}
}
@@ -98,22 +97,21 @@ BookmarkTreeNode* GetBookmarkTreeNode(ChromeBookmarkClient* client,
return bookmark_tree_node;
}
-void AddNode(ChromeBookmarkClient* client,
+void AddNode(BookmarkModel* model,
const BookmarkNode* node,
std::vector<linked_ptr<BookmarkTreeNode> >* nodes,
bool recurse) {
- return AddNodeHelper(client, node, nodes, recurse, false);
+ return AddNodeHelper(model, node, nodes, recurse, false);
}
-void AddNodeFoldersOnly(ChromeBookmarkClient* client,
+void AddNodeFoldersOnly(BookmarkModel* model,
const BookmarkNode* node,
std::vector<linked_ptr<BookmarkTreeNode> >* nodes,
bool recurse) {
- return AddNodeHelper(client, node, nodes, recurse, true);
+ return AddNodeHelper(model, node, nodes, recurse, true);
}
bool RemoveNode(BookmarkModel* model,
- ChromeBookmarkClient* client,
int64 id,
bool recursive,
std::string* error) {
@@ -126,8 +124,8 @@ bool RemoveNode(BookmarkModel* model,
*error = keys::kModifySpecialError;
return false;
}
- if (bookmarks::IsDescendantOf(node, client->managed_node()) ||
- bookmarks::IsDescendantOf(node, client->supervised_node())) {
+ if (bookmarks::IsDescendantOf(node, model->managed_node()) ||
+ bookmarks::IsDescendantOf(node, model->supervised_node())) {
*error = keys::kModifyManagedError;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698