Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 12036071: Fixing analyzer issues in DOM libs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 52c772168224c5d8b44187f5248994985efc118b..c3288ae05f7265c3289db3fe6a62d28b08e490f9 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -137,6 +137,9 @@ class _ChildrenElementList implements List {
}
}
+ List<Element> get reversed =>
+ new ReversedListView<Element>(this, 0, null);
+
void sort([int compare(Element a, Element b)]) {
throw new UnsupportedError('TODO(jacobr): should we impl?');
}
@@ -160,19 +163,19 @@ class _ChildrenElementList implements List {
}
void removeAll(Iterable elements) {
- Collections.removeAll(this, elements);
+ IterableMixinWorkaround.removeAll(this, elements);
}
void retainAll(Iterable elements) {
- Collections.retainAll(this, elements);
+ IterableMixinWorkaround.retainAll(this, elements);
}
void removeMatching(bool test(Element element)) {
- Collections.removeMatching(this, test);
+ IterableMixinWorkaround.removeMatching(this, test);
}
void retainMatching(bool test(Element element)) {
- Collections.retainMatching(this, test);
+ IterableMixinWorkaround.retainMatching(this, test);
}
void removeRange(int start, int rangeLength) {
@@ -359,6 +362,9 @@ class _FrozenElementList implements List {
throw new UnsupportedError('');
}
+ List<Element> get reversed =>
+ new ReversedListView<Element>(this, 0, null);
+
void sort([int compare(Element a, Element b)]) {
throw new UnsupportedError('');
}

Powered by Google App Engine
This is Rietveld 408576698