Fixing analyzer issues in DOM libs.

sdk/lib/svg/dart2js/svg_dart2js.dart

Index: sdk/lib/svg/dart2js/svg_dart2js.dart
diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart
index dff8961c4e7ddac60c11bb0410d43f5c32c84af2..811dab00ba87eba0f726b488bdb9dc66e7475b17 100644
--- a/sdk/lib/svg/dart2js/svg_dart2js.dart
+++ b/sdk/lib/svg/dart2js/svg_dart2js.dart
@@ -2,6 +2,7 @@ library svg;
 
 import 'dart:async';
 import 'dart:collection';
+import 'dart:collection-dev';
 import 'dart:html';
 import 'dart:html_common';
 // DO NOT EDIT
@@ -3613,11 +3614,13 @@ class LengthList implements JavaScriptIndexingBehavior, List<Length> native "*SV
 
   void forEach(void f(Length element)) => IterableMixinWorkaround.forEach(this, f);
 
-  String join([String separator]) => IterableMixinWorkaround.joinList(this, separator);
+  String join([String separator]) =>
+      IterableMixinWorkaround.joinList(this, separator);
 
   List mappedBy(f(Length element)) => IterableMixinWorkaround.mappedByList(this, f);
 
-  Iterable<Length> where(bool f(Length element)) => IterableMixinWorkaround.where(this, f);
+  Iterable<Length> where(bool f(Length element)) =>
+      IterableMixinWorkaround.where(this, f);
 
   bool every(bool f(Length element)) => IterableMixinWorkaround.every(this, f);
 
@@ -3677,6 +3680,9 @@ class LengthList implements JavaScriptIndexingBehavior, List<Length> native "*SV
 
   // clear() defined by IDL.
 
+  List<Length> get reversed =>
+      new ReversedListView<Length>(this, 0, null);

[Lasse Reichstein Nielsen, 2013/01/24 06:55:45]

We should probably make the class private, and have an
IterableMixinWorkaround.reverseList method.

+
   void sort([int compare(Length a, Length b)]) {
     throw new UnsupportedError("Cannot sort immutable List.");
   }
@@ -3705,9 +3711,11 @@ class LengthList implements JavaScriptIndexingBehavior, List<Length> native "*SV
     throw new StateError("More than one element");
   }
 
-  Length min([int compare(Length a, Length b)]) => IterableMixinWorkaround.min(this, compare);
+  Length min([int compare(Length a, Length b)]) =>
+      IterableMixinWorkaround.min(this, compare);
 
-  Length max([int compare(Length a, Length b)]) => IterableMixinWorkaround.max(this, compare);
+  Length max([int compare(Length a, Length b)]) =>
+      IterableMixinWorkaround.max(this, compare);
 
   Length removeAt(int pos) {
     throw new UnsupportedError("Cannot remove from immutable List.");
@@ -4290,11 +4298,13 @@ class NumberList implements JavaScriptIndexingBehavior, List<Number> native "*SV
 
   void forEach(void f(Number element)) => IterableMixinWorkaround.forEach(this, f);
 
-  String join([String separator]) => IterableMixinWorkaround.joinList(this, separator);
+  String join([String separator]) =>
+      IterableMixinWorkaround.joinList(this, separator);
 
   List mappedBy(f(Number element)) => IterableMixinWorkaround.mappedByList(this, f);
 
-  Iterable<Number> where(bool f(Number element)) => IterableMixinWorkaround.where(this, f);
+  Iterable<Number> where(bool f(Number element)) =>
+      IterableMixinWorkaround.where(this, f);
 
   bool every(bool f(Number element)) => IterableMixinWorkaround.every(this, f);
 
@@ -4354,6 +4364,9 @@ class NumberList implements JavaScriptIndexingBehavior, List<Number> native "*SV
 
   // clear() defined by IDL.
 
+  List<Number> get reversed =>
+      new ReversedListView<Number>(this, 0, null);
+
   void sort([int compare(Number a, Number b)]) {
     throw new UnsupportedError("Cannot sort immutable List.");
   }
@@ -4382,9 +4395,11 @@ class NumberList implements JavaScriptIndexingBehavior, List<Number> native "*SV
     throw new StateError("More than one element");
   }
 
-  Number min([int compare(Number a, Number b)]) => IterableMixinWorkaround.min(this, compare);
+  Number min([int compare(Number a, Number b)]) =>
+      IterableMixinWorkaround.min(this, compare);
 
-  Number max([int compare(Number a, Number b)]) => IterableMixinWorkaround.max(this, compare);
+  Number max([int compare(Number a, Number b)]) =>
+      IterableMixinWorkaround.max(this, compare);
 
   Number removeAt(int pos) {
     throw new UnsupportedError("Cannot remove from immutable List.");
@@ -5189,11 +5204,13 @@ class PathSegList implements JavaScriptIndexingBehavior, List<PathSeg> native "*
 
   void forEach(void f(PathSeg element)) => IterableMixinWorkaround.forEach(this, f);
 
-  String join([String separator]) => IterableMixinWorkaround.joinList(this, separator);
+  String join([String separator]) =>
+      IterableMixinWorkaround.joinList(this, separator);
 
   List mappedBy(f(PathSeg element)) => IterableMixinWorkaround.mappedByList(this, f);
 
-  Iterable<PathSeg> where(bool f(PathSeg element)) => IterableMixinWorkaround.where(this, f);
+  Iterable<PathSeg> where(bool f(PathSeg element)) =>
+      IterableMixinWorkaround.where(this, f);
 
   bool every(bool f(PathSeg element)) => IterableMixinWorkaround.every(this, f);
 
@@ -5253,6 +5270,9 @@ class PathSegList implements JavaScriptIndexingBehavior, List<PathSeg> native "*
 
   // clear() defined by IDL.
 
+  List<PathSeg> get reversed =>
+      new ReversedListView<PathSeg>(this, 0, null);
+
   void sort([int compare(PathSeg a, PathSeg b)]) {
     throw new UnsupportedError("Cannot sort immutable List.");
   }
@@ -5281,9 +5301,11 @@ class PathSegList implements JavaScriptIndexingBehavior, List<PathSeg> native "*
     throw new StateError("More than one element");
   }
 
-  PathSeg min([int compare(PathSeg a, PathSeg b)]) => IterableMixinWorkaround.min(this, compare);
+  PathSeg min([int compare(PathSeg a, PathSeg b)]) =>
+      IterableMixinWorkaround.min(this, compare);
 
-  PathSeg max([int compare(PathSeg a, PathSeg b)]) => IterableMixinWorkaround.max(this, compare);
+  PathSeg max([int compare(PathSeg a, PathSeg b)]) =>
+      IterableMixinWorkaround.max(this, compare);
 
   PathSeg removeAt(int pos) {
     throw new UnsupportedError("Cannot remove from immutable List.");
@@ -6107,11 +6129,13 @@ class StringList implements JavaScriptIndexingBehavior, List<String> native "*SV
 
   void forEach(void f(String element)) => IterableMixinWorkaround.forEach(this, f);
 
-  String join([String separator]) => IterableMixinWorkaround.joinList(this, separator);
+  String join([String separator]) =>
+      IterableMixinWorkaround.joinList(this, separator);
 
   List mappedBy(f(String element)) => IterableMixinWorkaround.mappedByList(this, f);
 
-  Iterable<String> where(bool f(String element)) => IterableMixinWorkaround.where(this, f);
+  Iterable<String> where(bool f(String element)) =>
+      IterableMixinWorkaround.where(this, f);
 
   bool every(bool f(String element)) => IterableMixinWorkaround.every(this, f);
 
@@ -6171,6 +6195,9 @@ class StringList implements JavaScriptIndexingBehavior, List<String> native "*SV
 
   // clear() defined by IDL.
 
+  List<String> get reversed =>
+      new ReversedListView<String>(this, 0, null);
+
   void sort([int compare(String a, String b)]) {
     throw new UnsupportedError("Cannot sort immutable List.");
   }
@@ -6199,9 +6226,11 @@ class StringList implements JavaScriptIndexingBehavior, List<String> native "*SV
     throw new StateError("More than one element");
   }
 
-  String min([int compare(String a, String b)]) => IterableMixinWorkaround.min(this, compare);
+  String min([int compare(String a, String b)]) =>
+      IterableMixinWorkaround.min(this, compare);
 
-  String max([int compare(String a, String b)]) => IterableMixinWorkaround.max(this, compare);
+  String max([int compare(String a, String b)]) =>
+      IterableMixinWorkaround.max(this, compare);
 
   String removeAt(int pos) {
     throw new UnsupportedError("Cannot remove from immutable List.");
@@ -7320,11 +7349,13 @@ class TransformList implements List<Transform>, JavaScriptIndexingBehavior nativ
 
   void forEach(void f(Transform element)) => IterableMixinWorkaround.forEach(this, f);
 
-  String join([String separator]) => IterableMixinWorkaround.joinList(this, separator);
+  String join([String separator]) =>
+      IterableMixinWorkaround.joinList(this, separator);
 
   List mappedBy(f(Transform element)) => IterableMixinWorkaround.mappedByList(this, f);
 
-  Iterable<Transform> where(bool f(Transform element)) => IterableMixinWorkaround.where(this, f);
+  Iterable<Transform> where(bool f(Transform element)) =>
+      IterableMixinWorkaround.where(this, f);
 
   bool every(bool f(Transform element)) => IterableMixinWorkaround.every(this, f);
 
@@ -7384,6 +7415,9 @@ class TransformList implements List<Transform>, JavaScriptIndexingBehavior nativ
 
   // clear() defined by IDL.
 
+  List<Transform> get reversed =>
+      new ReversedListView<Transform>(this, 0, null);
+
   void sort([int compare(Transform a, Transform b)]) {
     throw new UnsupportedError("Cannot sort immutable List.");
   }
@@ -7412,9 +7446,11 @@ class TransformList implements List<Transform>, JavaScriptIndexingBehavior nativ
     throw new StateError("More than one element");
   }
 
-  Transform min([int compare(Transform a, Transform b)]) => IterableMixinWorkaround.min(this, compare);
+  Transform min([int compare(Transform a, Transform b)]) =>
+      IterableMixinWorkaround.min(this, compare);
 
-  Transform max([int compare(Transform a, Transform b)]) => IterableMixinWorkaround.max(this, compare);
+  Transform max([int compare(Transform a, Transform b)]) =>
+      IterableMixinWorkaround.max(this, compare);
 
   Transform removeAt(int pos) {
     throw new UnsupportedError("Cannot remove from immutable List.");
@@ -7847,11 +7883,13 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List<ElementIn
 
   void forEach(void f(ElementInstance element)) => IterableMixinWorkaround.forEach(this, f);
 
-  String join([String separator]) => IterableMixinWorkaround.joinList(this, separator);
+  String join([String separator]) =>
+      IterableMixinWorkaround.joinList(this, separator);
 
   List mappedBy(f(ElementInstance element)) => IterableMixinWorkaround.mappedByList(this, f);
 
-  Iterable<ElementInstance> where(bool f(ElementInstance element)) => IterableMixinWorkaround.where(this, f);
+  Iterable<ElementInstance> where(bool f(ElementInstance element)) =>
+      IterableMixinWorkaround.where(this, f);
 
   bool every(bool f(ElementInstance element)) => IterableMixinWorkaround.every(this, f);
 
@@ -7913,6 +7951,9 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List<ElementIn
     throw new UnsupportedError("Cannot clear immutable List.");
   }
 
+  List<ElementInstance> get reversed =>
+      new ReversedListView<ElementInstance>(this, 0, null);
+
   void sort([int compare(ElementInstance a, ElementInstance b)]) {
     throw new UnsupportedError("Cannot sort immutable List.");
   }
@@ -7941,9 +7982,11 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List<ElementIn
     throw new StateError("More than one element");
   }
 
-  ElementInstance min([int compare(ElementInstance a, ElementInstance b)]) => IterableMixinWorkaround.min(this, compare);
+  ElementInstance min([int compare(ElementInstance a, ElementInstance b)]) =>
+      IterableMixinWorkaround.min(this, compare);
 
-  ElementInstance max([int compare(ElementInstance a, ElementInstance b)]) => IterableMixinWorkaround.max(this, compare);
+  ElementInstance max([int compare(ElementInstance a, ElementInstance b)]) =>
+      IterableMixinWorkaround.max(this, compare);
 
   ElementInstance removeAt(int pos) {
     throw new UnsupportedError("Cannot remove from immutable List.");