sdk/lib/_internal/compiler/js_lib/js_helper.dart - Issue 1203523003: Revert "Fix for issue 23432."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_helper.dart

Issue 1203523003: Revert "Fix for issue 23432." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/js_lib/js_helper.dart

diff --git a/sdk/lib/_internal/compiler/js_lib/js_helper.dart b/sdk/lib/_internal/compiler/js_lib/js_helper.dart

index 5d23f3a8c8f1dad2b254e2f527aca5c932d72123..4270ab576d2e43084f28ac99258d89c433f6be9a 100644

--- a/sdk/lib/_internal/compiler/js_lib/js_helper.dart

+++ b/sdk/lib/_internal/compiler/js_lib/js_helper.dart

@@ -210,7 +210,7 @@ String S(value) {

return 'null';

}

var res = value.toString();

- if (res is !String) throw _argumentError(value);

+ if (res is !String) throw argumentErrorValue(value);

return res;

}