Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: sdk/lib/_internal/compiler/js_lib/js_helper.dart

Issue 1203523003: Revert "Fix for issue 23432." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library _js_helper; 5 library _js_helper;
6 6
7 import 'dart:_async_await_error_codes' as async_error_codes; 7 import 'dart:_async_await_error_codes' as async_error_codes;
8 8
9 import 'dart:_js_embedded_names' show 9 import 'dart:_js_embedded_names' show
10 DEFERRED_LIBRARY_URIS, 10 DEFERRED_LIBRARY_URIS,
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 return JS('String', r'"" + (#)', value); 203 return JS('String', r'"" + (#)', value);
204 } 204 }
205 } else if (true == value) { 205 } else if (true == value) {
206 return 'true'; 206 return 'true';
207 } else if (false == value) { 207 } else if (false == value) {
208 return 'false'; 208 return 'false';
209 } else if (value == null) { 209 } else if (value == null) {
210 return 'null'; 210 return 'null';
211 } 211 }
212 var res = value.toString(); 212 var res = value.toString();
213 if (res is !String) throw _argumentError(value); 213 if (res is !String) throw argumentErrorValue(value);
214 return res; 214 return res;
215 } 215 }
216 216
217 createInvocationMirror(String name, internalName, kind, arguments, 217 createInvocationMirror(String name, internalName, kind, arguments,
218 argumentNames) { 218 argumentNames) {
219 return new JSInvocationMirror(name, 219 return new JSInvocationMirror(name,
220 internalName, 220 internalName,
221 kind, 221 kind,
222 arguments, 222 arguments,
223 argumentNames); 223 argumentNames);
(...skipping 3905 matching lines...) Expand 10 before | Expand all | Expand 10 after
4129 // This is a function that will return a helper function that does the 4129 // This is a function that will return a helper function that does the
4130 // iteration of the sync*. 4130 // iteration of the sync*.
4131 // 4131 //
4132 // Each invocation should give a body with fresh state. 4132 // Each invocation should give a body with fresh state.
4133 final dynamic /* js function */ _outerHelper; 4133 final dynamic /* js function */ _outerHelper;
4134 4134
4135 SyncStarIterable(this._outerHelper); 4135 SyncStarIterable(this._outerHelper);
4136 4136
4137 Iterator get iterator => new SyncStarIterator(JS('', '#()', _outerHelper)); 4137 Iterator get iterator => new SyncStarIterator(JS('', '#()', _outerHelper));
4138 } 4138 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/js_lib/interceptors.dart ('k') | tests/compiler/dart2js_extra/dart2js_extra.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698