Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 12035081: IndexedDB: Specify reason when aborting due to quota (Closed)

Created:
7 years, 11 months ago by jsbell
Modified:
7 years, 10 months ago
Reviewers:
dgrogan, alecflett
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

IndexedDB: Specify reason when aborting due to quota When aborting a transaction due to quota, specify QuotaExceededError so script can distinguish this from other causes. Requires some WebKit API plumbing, which is coming in http://wkbug.com/107851 R=alecflett@chromium.org,dgrogan@chromium.org BUG=113118 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179689

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M content/test/data/indexeddb/quota_test.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jsbell
alec, can you please take a look?
7 years, 11 months ago (2013-01-24 20:01:28 UTC) #1
alecflett
On 2013/01/24 20:01:28, jsbell wrote: > alec, can you please take a look? lgtm
7 years, 11 months ago (2013-01-24 20:15:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/12035081/1
7 years, 10 months ago (2013-01-29 23:11:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=46782
7 years, 10 months ago (2013-01-30 01:47:11 UTC) #4
jsbell
Re-uploading; not sure why win was failing to apply the patch, there were no conflicts.
7 years, 10 months ago (2013-01-30 17:24:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/12035081/16001
7 years, 10 months ago (2013-01-30 17:25:48 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-01-30 20:16:28 UTC) #7
Message was sent while issue was closed.
Change committed as 179689

Powered by Google App Engine
This is Rietveld 408576698