Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12035029: Finish migrating cc/ from WebKit::WebTransformationMatrix to gfx::Transform (Closed)

Created:
7 years, 11 months ago by ajuma
Modified:
7 years, 11 months ago
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, cc-bugs_chromium.org, darin-cc_chromium.org, jonathan.backer, enne (OOO)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Finish migrating cc/ from WebKit::WebTransformationMatrix to gfx::Transform BUG=166640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178931

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -282 lines) Patch
M cc/animation_curve.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/keyframed_animation_curve.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/keyframed_animation_curve.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/keyframed_animation_curve_unittest.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M cc/layer_animation_controller.cc View 2 chunks +1 line, -25 lines 0 comments Download
M cc/test/animation_test_common.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/animation_test_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/geometry_test_utils.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/test/geometry_test_utils.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M cc/transform_operation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/transform_operation.cc View 9 chunks +22 lines, -17 lines 0 comments Download
M cc/transform_operations.h View 1 4 chunks +6 lines, -7 lines 0 comments Download
M cc/transform_operations.cc View 1 9 chunks +22 lines, -23 lines 0 comments Download
M cc/transform_operations_unittest.cc View 26 chunks +88 lines, -88 lines 0 comments Download
M ui/compositor/transform_animation_curve_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/transform_animation_curve_adapter.cc View 3 chunks +4 lines, -32 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/web_layer_impl.cc View 3 chunks +4 lines, -29 lines 0 comments Download
M webkit/compositor_bindings/web_transform_animation_curve_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_transform_operations_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/compositor_bindings/web_transformation_matrix_unittest.cc View 11 chunks +27 lines, -10 lines 0 comments Download
A webkit/compositor_bindings/web_transformation_matrix_util.h View 1 chunk +24 lines, -0 lines 0 comments Download
A webkit/compositor_bindings/web_transformation_matrix_util.cc View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ajuma
7 years, 11 months ago (2013-01-22 19:14:53 UTC) #1
Ian Vollick
lgtm! One nit: https://codereview.chromium.org/12035029/diff/1/webkit/compositor_bindings/web_transformation_matrix_util.cc File webkit/compositor_bindings/web_transformation_matrix_util.cc (right): https://codereview.chromium.org/12035029/diff/1/webkit/compositor_bindings/web_transformation_matrix_util.cc#newcode15 webkit/compositor_bindings/web_transformation_matrix_util.cc:15: gfx::Transform transform; We do have such ...
7 years, 11 months ago (2013-01-25 17:59:15 UTC) #2
danakj
https://codereview.chromium.org/12035029/diff/1/cc/transform_operations.h File cc/transform_operations.h (right): https://codereview.chromium.org/12035029/diff/1/cc/transform_operations.h#newcode64 cc/transform_operations.h:64: gfx::Transform& result) const; Can you make this into a ...
7 years, 11 months ago (2013-01-25 18:04:03 UTC) #3
ajuma
+enne for compositor_bindings OWNERS. https://codereview.chromium.org/12035029/diff/1/cc/transform_operations.h File cc/transform_operations.h (right): https://codereview.chromium.org/12035029/diff/1/cc/transform_operations.h#newcode64 cc/transform_operations.h:64: gfx::Transform& result) const; On 2013/01/25 ...
7 years, 11 months ago (2013-01-25 19:28:26 UTC) #4
enne (OOO)
compositor bindings lgtm
7 years, 11 months ago (2013-01-25 20:07:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/12035029/7001
7 years, 11 months ago (2013-01-25 20:36:14 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 22:56:48 UTC) #7
Message was sent while issue was closed. 
Change committed as 178931

Powered by Google App Engine
This is Rietveld 408576698