Issue 12035027: Revert 178037

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12035027: Revert 178037 (Closed)

Created:
7 years, 11 months ago by cpu_(ooo_6.6-7.5)

Modified:
7 years, 11 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, robertshield, jam, kkania

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 178037 It broke android. > Fix official builder compile error when building aura on windows > > The error is in the chrome_frame_common project > chrome_frame_automation.cc (833) : error C2440: '=' cannot convert from HWND to gfx::NativeWindow > > That is because in aura the gfx::NativeWindow is a aura::Window* instead of HWND > > BUG=171018 > TEST=see bug > Review URL: https://codereview.chromium.org/12022038 TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178043

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -28 lines)			Patch
M	chrome/common/automation_messages.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/automation_messages_internal.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/test/automation/automation_proxy.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/automation/automation_proxy.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/common/content_message_generator.cc	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	content/public/common/common_param_traits.h	View	1 chunk	+1 line, -18 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages