Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 12022038: Fix official builder compile error when building aura on windows (Closed)

Created:
7 years, 11 months ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 11 months ago
Reviewers:
robertshield, kkania, jam, robert
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, robertshield, kkania
Visibility:
Public.

Description

Fix official builder compile error when building aura on windows The error is in the chrome_frame_common project chrome_frame_automation.cc (833) : error C2440: '=' cannot convert from HWND to gfx::NativeWindow That is because in aura the gfx::NativeWindow is a aura::Window* instead of HWND BUG=171018 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178037

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -35 lines) Patch
M chrome/common/automation_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/automation_messages_internal.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/content_message_generator.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M content/public/common/common_param_traits.h View 1 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
Trying to fix the official build of aura/ash see bug. I really not sure what ...
7 years, 11 months ago (2013-01-19 03:01:35 UTC) #1
cpu_(ooo_6.6-7.5)
+jam for owners check
7 years, 11 months ago (2013-01-20 21:51:23 UTC) #2
robertshield
LGTM, this will at least build. Any type that can be typedef'ed into something other ...
7 years, 11 months ago (2013-01-21 16:46:59 UTC) #3
jam
7 years, 11 months ago (2013-01-22 07:07:21 UTC) #4
lgtm

On 2013/01/21 16:46:59, robertshield wrote:
> LGTM, this will at least build. Any type that can be typedef'ed into something
> other than a native window handle isn't right for the CreateExternalTab IPC
> message. 
> 
> I've been punting on making CF + Aura really work, it shouldn't be too hard in
> theory. In any case this is fine for now IMO.

it'd be great if this can be looked at sooner rather than later; i.e. it will
either block aura windows going to all users, or CF will break if it's pushed
out. neither of these situations are desirable.

Powered by Google App Engine
This is Rietveld 408576698