Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: sync/syncable/model_type.cc

Issue 12033093: sync: Implementation of Priority Preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: another rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/syncable/model_type.cc
diff --git a/sync/syncable/model_type.cc b/sync/syncable/model_type.cc
index d41fe0275252e96e64386ecf7125914753382b15..03d749f5afa84f1bded51f513897fcd63cabae68 100644
--- a/sync/syncable/model_type.cc
+++ b/sync/syncable/model_type.cc
@@ -351,6 +351,9 @@ ModelTypeSet EncryptableUserTypes() {
encryptable_user_types.Remove(HISTORY_DELETE_DIRECTIVES);
// Synced notifications are not encrypted since the server must see changes.
encryptable_user_types.Remove(SYNCED_NOTIFICATIONS);
+ // Priority preferences are not encrypted because they might be synced before
+ // encryption is ready.
+ encryptable_user_types.Remove(PRIORITY_PREFERENCES);
Nicolas Zea 2013/02/21 23:41:11 RemoveAll(PriorityUserTypes())?
albertb 2013/02/22 20:08:47 Done.
// Proxy types have no sync representation and are therefore not encrypted.
// Note however that proxy types map to one or more protocol types, which
// may or may not be encrypted themselves.
@@ -358,6 +361,10 @@ ModelTypeSet EncryptableUserTypes() {
return encryptable_user_types;
}
+ModelTypeSet PriorityUserTypes() {
+ return ModelTypeSet(PRIORITY_PREFERENCES);
+}
+
ModelTypeSet ControlTypes() {
ModelTypeSet set;
// TODO(sync): We should be able to build the actual enumset's internal
@@ -367,9 +374,6 @@ ModelTypeSet ControlTypes() {
set.Put(ModelTypeFromInt(i));
}
- // TODO(albertb): Re-enable this when the server supports it.
- set.Remove(PRIORITY_PREFERENCES);
-
return set;
}

Powered by Google App Engine
This is Rietveld 408576698