Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5506)

Unified Diff: chrome/browser/sync/sync_prefs_unittest.cc

Issue 12033093: sync: Implementation of Priority Preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: another rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sync_prefs_unittest.cc
diff --git a/chrome/browser/sync/sync_prefs_unittest.cc b/chrome/browser/sync/sync_prefs_unittest.cc
index ea114f2b4bdfa1a199ae317dbd8db9624d94de2c..43a64772e2a35c499b01bf9d3d27676777a03cb9 100644
--- a/chrome/browser/sync/sync_prefs_unittest.cc
+++ b/chrome/browser/sync/sync_prefs_unittest.cc
@@ -68,7 +68,7 @@ TEST_F(SyncPrefsTest, PreferredTypesKeepEverythingSynced) {
const syncer::ModelTypeSet user_types = syncer::UserTypes();
EXPECT_TRUE(user_types.Equals(
sync_prefs.GetPreferredDataTypes(user_types)));
- const syncer::ModelTypeSet user_visible_types = syncer::UserSelectableTypes();
+ const syncer::ModelTypeSet user_visible_types = GetUserVisibleTypes();
Nicolas Zea 2013/02/21 23:41:11 Why did this change?
albertb 2013/02/22 20:08:47 Oops, probably a bad conflict resolve.
for (syncer::ModelTypeSet::Iterator it = user_visible_types.First();
it.Good(); it.Inc()) {
syncer::ModelTypeSet preferred_types;
@@ -87,7 +87,7 @@ TEST_F(SyncPrefsTest, PreferredTypesNotKeepEverythingSynced) {
const syncer::ModelTypeSet user_types = syncer::UserTypes();
EXPECT_TRUE(user_types.Equals(
sync_prefs.GetPreferredDataTypes(user_types)));
- const syncer::ModelTypeSet user_visible_types = syncer::UserSelectableTypes();
+ const syncer::ModelTypeSet user_visible_types = GetUserVisibleTypes();
for (syncer::ModelTypeSet::Iterator it = user_visible_types.First();
it.Good(); it.Inc()) {
syncer::ModelTypeSet preferred_types;
@@ -98,6 +98,7 @@ TEST_F(SyncPrefsTest, PreferredTypesNotKeepEverythingSynced) {
}
if (it.Get() == syncer::PREFERENCES) {
expected_preferred_types.Put(syncer::DICTIONARY);
+ expected_preferred_types.Put(syncer::PRIORITY_PREFERENCES);
expected_preferred_types.Put(syncer::SEARCH_ENGINES);
}
if (it.Get() == syncer::APPS) {
@@ -112,6 +113,11 @@ TEST_F(SyncPrefsTest, PreferredTypesNotKeepEverythingSynced) {
expected_preferred_types.Put(syncer::FAVICON_IMAGES);
expected_preferred_types.Put(syncer::FAVICON_TRACKING);
}
+ // TODO(akalin): Remove this when history delete directives are
+ // registered by default.
+ if (it.Get() == syncer::HISTORY_DELETE_DIRECTIVES) {
+ expected_preferred_types.Clear();
+ }
sync_prefs.SetPreferredDataTypes(user_types, preferred_types);
EXPECT_TRUE(expected_preferred_types.Equals(
sync_prefs.GetPreferredDataTypes(user_types)));

Powered by Google App Engine
This is Rietveld 408576698