Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1203293002: Fix generate_split_manifest.py depending on third-party "lxml" import (Closed)

Created:
5 years, 6 months ago by agrieve
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix generate_split_manifest.py depending on third-party "lxml" import Python's xml module works just fine. BUG=484797 Committed: https://crrev.com/11c73372d5f5718227a44ffc98d8ea2634d80170 Cr-Commit-Position: refs/heads/master@{#336387}

Patch Set 1 #

Patch Set 2 : sort imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/gyp/generate_split_manifest.py View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
agrieve
5 years, 6 months ago (2015-06-25 00:49:06 UTC) #2
agrieve
MTV is away today, so hoping pasko or jochen can look at this?
5 years, 6 months ago (2015-06-26 15:02:11 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-26 15:17:59 UTC) #5
agrieve
On 2015/06/26 15:17:59, jochen wrote: > lgtm thanks!
5 years, 6 months ago (2015-06-26 15:23:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1203293002/20001
5 years, 6 months ago (2015-06-26 15:24:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-26 16:44:21 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 16:45:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11c73372d5f5718227a44ffc98d8ea2634d80170
Cr-Commit-Position: refs/heads/master@{#336387}

Powered by Google App Engine
This is Rietveld 408576698