Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: build/android/gyp/generate_split_manifest.py

Issue 1203293002: Fix generate_split_manifest.py depending on third-party "lxml" import (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sort imports Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/generate_split_manifest.py
diff --git a/build/android/gyp/generate_split_manifest.py b/build/android/gyp/generate_split_manifest.py
index 93b55027dbba107dc390222cf039f52f77d68489..9cb3bca4b55f894fc1a9293eed7360b7500a0c6f 100755
--- a/build/android/gyp/generate_split_manifest.py
+++ b/build/android/gyp/generate_split_manifest.py
@@ -9,8 +9,8 @@ Given the manifest file for the main APK, generates an AndroidManifest.xml with
the value required for a Split APK (package, versionCode, etc).
"""
-import lxml.etree
import optparse
+import xml.etree.ElementTree
from util import build_utils
@@ -66,8 +66,8 @@ def Build(main_manifest, split, has_code):
The XML split manifest as a string
"""
- doc = lxml.etree.fromstring(main_manifest)
- package = doc.xpath('/manifest/@package')[0]
+ doc = xml.etree.ElementTree.fromstring(main_manifest)
+ package = doc.get('package')
return MANIFEST_TEMPLATE % {
'package': package,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698