chrome/browser/extensions/api/system_storage/storage_api_test_util.cc - Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_storage/storage_api_test_util.cc

Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc ('K') | « chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc ('k') | chrome/browser/extensions/api/system_storage/storage_info_provider.cc » ('j') | chrome/browser/extensions/api/system_storage/storage_info_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_storage/storage_api_test_util.cc

diff --git a/chrome/browser/extensions/api/system_storage/storage_api_test_util.cc b/chrome/browser/extensions/api/system_storage/storage_api_test_util.cc

index 2f594f5fac5c93d78469635d69a3c5ccd89f6988..4fad80df8238add2b828298cdfdd47242fbbec1f 100644

--- a/chrome/browser/extensions/api/system_storage/storage_api_test_util.cc

+++ b/chrome/browser/extensions/api/system_storage/storage_api_test_util.cc

@@ -17,9 +17,8 @@ storage_monitor::StorageInfo BuildStorageInfoFromTestStorageUnitInfo(

const TestStorageUnitInfo& unit) {

return storage_monitor::StorageInfo(

unit.device_id,

- base::UTF8ToUTF16(unit.name),

base::FilePath::StringType(), /* no location */

- base::string16(), /* no storage label */

+ base::UTF8ToUTF16(unit.name), /* storage label */

vandebo (ex-Chrome) 2014/03/03 19:58:31 nit: unit.name -> unit.label

Haojian Wu 2014/03/04 05:00:12 Since TestStorageUnitInfo should be consistent wit

base::string16(), /* no storage vendor */

base::string16(), /* no storage model */

unit.capacity);