chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc - Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc

Issue 120303003: [StorageMonitor] Move gallery name generation to StorageInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc ('k') | chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc » ('j') | chrome/browser/extensions/api/system_storage/storage_api_test_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc

diff --git a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc

index a2511b12877c6bffb77bbbe588f453d4afb1d5a7..8f1af121a830b7c336d3aca6b93de6bd9158b87b 100644

--- a/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc

+++ b/chrome/browser/extensions/api/media_galleries_private/media_galleries_private_apitest.cc

@@ -19,7 +19,6 @@

#include "content/public/test/browser_test_utils.h"

#include "extensions/browser/extension_system.h"

#include "extensions/common/extension.h"

-#include "url/gurl.h"

using storage_monitor::StorageInfo;

using storage_monitor::StorageMonitor;

@@ -93,8 +92,9 @@ class MediaGalleriesPrivateApiTest : public ExtensionApiTest {

void Attach() {

DCHECK(StorageMonitor::GetInstance()->IsInitialized());

- StorageInfo info(device_id_, base::ASCIIToUTF16(kDeviceName), kDevicePath,

- base::string16(), base::string16(), base::string16(), 0);

+ StorageInfo info(device_id_, kDevicePath,

+ base::ASCIIToUTF16(kDeviceName), base::string16(),

vandebo (ex-Chrome) 2014/03/03 19:58:31 rename constant

Haojian Wu 2014/03/04 05:00:12 Done.

vandebo (ex-Chrome) 2014/03/04 19:24:47 Sorry, I meant rename kDeviceName to something lik

Haojian Wu 2014/03/05 07:28:09 Done.

+ base::string16(), 0);

StorageMonitor::GetInstance()->receiver()->ProcessAttach(info);

content::RunAllPendingInMessageLoop();

}