Issue 1202923002: Revert "Deprecating high-conflict accelerators"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1202923002: Revert "Deprecating high-conflict accelerators" (Closed)

Created:
5 years, 6 months ago by afakhry

Modified:
5 years, 6 months ago

Reviewers:
Lei Zhang, Mark P, oshima, sky, xiyuan

CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, mazda+watch_chromium.org, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Deprecating high-conflict accelerators" This reverts commit c2b81c9fca4abc10cafdc75d2e7b4f15314e2e5b. We missed the cutoff for M45. We'll try again post-branch in M46. TBR=thestig@chromium.org, xiyuan@chromium.org, oshima@chromium.org, mpearson@chromium.org, sky@chromium.org BUG=492454, 486198, 498565, 405317 Committed: https://chromium.googlesource.com/chromium/src/+/0322ca434c0ae0056ab5b9e9bd0045bb1920a4a1

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -365 lines)			Patch
M	ash/accelerators/accelerator_controller.h	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	ash/accelerators/accelerator_controller.cc	View	7 chunks	+4 lines, -91 lines	0 comments	Download
M	ash/accelerators/accelerator_controller_unittest.cc	View	2 chunks	+0 lines, -94 lines	0 comments	Download
M	ash/accelerators/accelerator_table.h	View	1 chunk	+0 lines, -36 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	5 chunks	+2 lines, -45 lines	0 comments	Download
M	ash/accelerators/accelerator_table_unittest.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	ash/ash_chromeos_strings.grdp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	ash/system/system_notifier.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/system/system_notifier.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/chromeos/keyboard_overlay_data.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/ash_util.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/ash/ash_util.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/accelerator_table.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	3 chunks	+0 lines, -11 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	2 chunks	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

afakhry

5 years, 6 months ago (2015-06-23 21:44:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0322ca434c0ae0056ab5b9e9bd0045bb1920a4a1.

Expand Messages | Collapse Messages