Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Side by Side Diff: ash/accelerators/accelerator_table.h

Issue 1202923002: Revert "Deprecating high-conflict accelerators" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_ACCELERATORS_ACCELERATOR_TABLE_H_ 5 #ifndef ASH_ACCELERATORS_ACCELERATOR_TABLE_H_
6 #define ASH_ACCELERATORS_ACCELERATOR_TABLE_H_ 6 #define ASH_ACCELERATORS_ACCELERATOR_TABLE_H_
7 7
8 #include "ash/ash_export.h" 8 #include "ash/ash_export.h"
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "ui/events/event_constants.h" 10 #include "ui/events/event_constants.h"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 #endif 146 #endif
147 }; 147 };
148 148
149 struct AcceleratorData { 149 struct AcceleratorData {
150 bool trigger_on_press; 150 bool trigger_on_press;
151 ui::KeyboardCode keycode; 151 ui::KeyboardCode keycode;
152 int modifiers; 152 int modifiers;
153 AcceleratorAction action; 153 AcceleratorAction action;
154 }; 154 };
155 155
156 // Gathers the needed data to handle deprecated accelerators.
157 struct DeprecatedAcceleratorData {
158 // The old deprecated accelerator.
159 AcceleratorData deprecated_accelerator;
160
161 // The name of the UMA histogram that will be used to measure the deprecated
162 // v.s. new accelerator usage.
163 const char* uma_histogram_name;
164
165 // The ID of the localized notification message to show to users informing
166 // them about the deprecation.
167 int notification_message_id;
168
169 // Specifies whether the deprecated accelerator is still enabled to do its
170 // associated action.
171 bool deprecated_enabled;
172 };
173
174 // The ID of the MessageCenter notifications of deprecated accelerators.
175 const char kDeprecatedAcceleratorNotificationId[] = "deprecated_accelerator";
176
177 // This will be used for the UMA stats to measure the how many users are using
178 // the old v.s. new accelerators.
179 enum DeprecatedAcceleratorUsage {
180 DEPRECATED_USED = 0, // The deprecated accelerator is used.
181 NEW_USED, // The new accelerator is used.
182 DEPRECATED_USAGE_COUNT, // Maximum value of this enum for histogram use.
183 };
184
185 // Accelerators handled by AcceleratorController. 156 // Accelerators handled by AcceleratorController.
186 ASH_EXPORT extern const AcceleratorData kAcceleratorData[]; 157 ASH_EXPORT extern const AcceleratorData kAcceleratorData[];
187 ASH_EXPORT extern const size_t kAcceleratorDataLength; 158 ASH_EXPORT extern const size_t kAcceleratorDataLength;
188 159
189 #if defined(OS_CHROMEOS)
190 // The list of the deprecated accelerators along with their new replacing ones
191 // and how to handle them.
192 ASH_EXPORT extern const DeprecatedAcceleratorData kDeprecatedAccelerators[];
193 ASH_EXPORT extern const size_t kDeprecatedAcceleratorsLength;
194 #endif // defined(OS_CHROMEOS)
195
196 // Debug accelerators. Debug accelerators are only enabled when the "Debugging 160 // Debug accelerators. Debug accelerators are only enabled when the "Debugging
197 // keyboard shortcuts" flag (--ash-debug-shortcuts) is enabled. Debug actions 161 // keyboard shortcuts" flag (--ash-debug-shortcuts) is enabled. Debug actions
198 // are always run (similar to reserved actions). 162 // are always run (similar to reserved actions).
199 ASH_EXPORT extern const AcceleratorData kDebugAcceleratorData[]; 163 ASH_EXPORT extern const AcceleratorData kDebugAcceleratorData[];
200 ASH_EXPORT extern const size_t kDebugAcceleratorDataLength; 164 ASH_EXPORT extern const size_t kDebugAcceleratorDataLength;
201 165
202 // Actions that should be handled very early in Ash unless the current target 166 // Actions that should be handled very early in Ash unless the current target
203 // window is full-screen. 167 // window is full-screen.
204 ASH_EXPORT extern const AcceleratorAction kPreferredActions[]; 168 ASH_EXPORT extern const AcceleratorAction kPreferredActions[];
205 ASH_EXPORT extern const size_t kPreferredActionsLength; 169 ASH_EXPORT extern const size_t kPreferredActionsLength;
(...skipping 23 matching lines...) Expand all
229 ASH_EXPORT extern const AcceleratorAction kActionsAllowedInAppMode[]; 193 ASH_EXPORT extern const AcceleratorAction kActionsAllowedInAppMode[];
230 ASH_EXPORT extern const size_t kActionsAllowedInAppModeLength; 194 ASH_EXPORT extern const size_t kActionsAllowedInAppModeLength;
231 195
232 // Actions that require at least 1 window. 196 // Actions that require at least 1 window.
233 ASH_EXPORT extern const AcceleratorAction kActionsNeedingWindow[]; 197 ASH_EXPORT extern const AcceleratorAction kActionsNeedingWindow[];
234 ASH_EXPORT extern const size_t kActionsNeedingWindowLength; 198 ASH_EXPORT extern const size_t kActionsNeedingWindowLength;
235 199
236 } // namespace ash 200 } // namespace ash
237 201
238 #endif // ASH_ACCELERATORS_ACCELERATOR_TABLE_H_ 202 #endif // ASH_ACCELERATORS_ACCELERATOR_TABLE_H_
OLDNEW
« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | ash/accelerators/accelerator_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698