chrome/android/java/res/layout/eb_item.xml - Issue 1202713002: Replace enhanced bookmarks salient images with favicons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/eb_item.xml

Issue 1202713002: Replace enhanced bookmarks salient images with favicons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Line wraps in EnhanacedBookmarkItem.java Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/res/layout/eb_item.xml

diff --git a/chrome/android/java/res/layout/eb_item.xml b/chrome/android/java/res/layout/eb_item.xml

index 5fb9b1322eed7c6b5fd956c4c399561eb4705c6f..0612a15227ace4307b685379fc1426de61384839 100644

--- a/chrome/android/java/res/layout/eb_item.xml

+++ b/chrome/android/java/res/layout/eb_item.xml

@@ -17,10 +17,10 @@

android:orientation="horizontal"

android:padding="8dp" >

- <org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkSalientImageView

- android:id="@+id/bookamrk_image"

- android:layout_width="40dp"

- android:layout_height="40dp"

+ <ImageView

+ android:id="@+id/bookmark_image"

+ android:layout_width="@dimen/enhanced_bookmark_item_icon_size"

+ android:layout_height="@dimen/enhanced_bookmark_item_icon_size"

android:layout_margin="8dp"

android:layout_gravity="start|center"

android:scaleType="center"

@@ -42,14 +42,6 @@

android:textSize="16sp" />

<TextView

- android:id="@+id/url"

- android:layout_width="wrap_content"

- android:layout_height="wrap_content"

- android:singleLine="true"

- android:textColor="#8c000000"

- android:textSize="14sp" />

- <TextView

android:id="@+id/folder_title"

android:layout_width="0dp"

android:layout_height="0dp" />

« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/android/java/res/values/colors.xml » ('j') | no next file with comments »