Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: chrome/android/java/res/layout/eb_item.xml

Issue 1202713002: Replace enhanced bookmarks salient images with favicons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Line wraps in EnhanacedBookmarkItem.java Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/android/java/res/values/colors.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <view class="org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkItem" 6 <view class="org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkItem"
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 xmlns:chrome="http://schemas.android.com/apk/res-auto" 8 xmlns:chrome="http://schemas.android.com/apk/res-auto"
9 android:layout_width="wrap_content" 9 android:layout_width="wrap_content"
10 android:layout_height="wrap_content" > 10 android:layout_height="wrap_content" >
11 11
12 <!-- TODO(kkimlabs): Add content descrption to the ImageViews --> 12 <!-- TODO(kkimlabs): Add content descrption to the ImageViews -->
13 13
14 <LinearLayout 14 <LinearLayout
15 android:layout_width="match_parent" 15 android:layout_width="match_parent"
16 android:layout_height="wrap_content" 16 android:layout_height="wrap_content"
17 android:orientation="horizontal" 17 android:orientation="horizontal"
18 android:padding="8dp" > 18 android:padding="8dp" >
19 19
20 <org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkSalientIm ageView 20 <ImageView
21 android:id="@+id/bookamrk_image" 21 android:id="@+id/bookmark_image"
22 android:layout_width="40dp" 22 android:layout_width="@dimen/enhanced_bookmark_item_icon_size"
23 android:layout_height="40dp" 23 android:layout_height="@dimen/enhanced_bookmark_item_icon_size"
24 android:layout_margin="8dp" 24 android:layout_margin="8dp"
25 android:layout_gravity="start|center" 25 android:layout_gravity="start|center"
26 android:scaleType="center" 26 android:scaleType="center"
27 android:contentDescription="@null" /> 27 android:contentDescription="@null" />
28 28
29 <LinearLayout 29 <LinearLayout
30 android:layout_width="match_parent" 30 android:layout_width="match_parent"
31 android:layout_height="wrap_content" 31 android:layout_height="wrap_content"
32 android:orientation="vertical" 32 android:orientation="vertical"
33 android:padding="8dp" 33 android:padding="8dp"
34 android:paddingEnd="22dp" > 34 android:paddingEnd="22dp" >
35 35
36 <TextView 36 <TextView
37 android:id="@+id/title" 37 android:id="@+id/title"
38 android:layout_width="wrap_content" 38 android:layout_width="wrap_content"
39 android:layout_height="wrap_content" 39 android:layout_height="wrap_content"
40 android:singleLine="true" 40 android:singleLine="true"
41 android:textColor="#d9000000" 41 android:textColor="#d9000000"
42 android:textSize="16sp" /> 42 android:textSize="16sp" />
43 43
44 <TextView 44 <TextView
45 android:id="@+id/url"
46 android:layout_width="wrap_content"
47 android:layout_height="wrap_content"
48 android:singleLine="true"
49 android:textColor="#8c000000"
50 android:textSize="14sp" />
51
52 <TextView
53 android:id="@+id/folder_title" 45 android:id="@+id/folder_title"
54 android:layout_width="0dp" 46 android:layout_width="0dp"
55 android:layout_height="0dp" /> 47 android:layout_height="0dp" />
56 48
57 </LinearLayout> 49 </LinearLayout>
58 </LinearLayout> 50 </LinearLayout>
59 51
60 <org.chromium.chrome.browser.widget.TintedImageButton 52 <org.chromium.chrome.browser.widget.TintedImageButton
61 android:id="@+id/more" 53 android:id="@+id/more"
62 android:layout_width="wrap_content" 54 android:layout_width="wrap_content"
63 android:layout_height="wrap_content" 55 android:layout_height="wrap_content"
64 android:layout_gravity="end|center" 56 android:layout_gravity="end|center"
65 android:background="@null" 57 android:background="@null"
66 android:contentDescription="@string/accessibility_enhanced_bookmark_more _info" 58 android:contentDescription="@string/accessibility_enhanced_bookmark_more _info"
67 android:padding="10dp" 59 android:padding="10dp"
68 android:paddingStart="20dp" 60 android:paddingStart="20dp"
69 android:src="@drawable/eb_item_more" 61 android:src="@drawable/eb_item_more"
70 chrome:tint="@color/dark_mode_tint" /> 62 chrome:tint="@color/dark_mode_tint" />
71 63
72 <org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkItemHighlight View 64 <org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkItemHighlight View
73 android:id="@+id/highlight" 65 android:id="@+id/highlight"
74 android:layout_width="match_parent" 66 android:layout_width="match_parent"
75 android:layout_height="match_parent" /> 67 android:layout_height="match_parent" />
76 </view> 68 </view>
OLDNEW
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/android/java/res/values/colors.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698