Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1202563002: Subzero: Fix "make -f Makefile.standalone MINIMAL=1 check". (Closed)

Created:
5 years, 6 months ago by Jim Stichnoth
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix "make -f Makefile.standalone MINIMAL=1 check". Some recent ARM changes turned out to break the lit tests for the MINIMAL build. Two main issues: 1. ARM tests are currently asm-only, so allow_dump needs to be required. 2. GlobalContext::emitFileHeader() needs to return gracefully instead of calling report_fatal_error(), to allow error tests to produce the right error output. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c8799688d288c9acd71f0b4f193f9b1beac751aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -34 lines) Patch
M src/IceGlobalContext.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 chunk +8 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/arith.ll View 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/branch-opt.ll View 1 chunk +8 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/convert.ll View 1 chunk +8 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/function_aligned.ll View 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/int-arg.ll View 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/return_immediates.ll View 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/shift.ll View 1 chunk +8 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/test_i1.ll View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
5 years, 6 months ago (2015-06-22 19:52:14 UTC) #2
Karl
lgtm
5 years, 6 months ago (2015-06-22 20:00:22 UTC) #3
Jim Stichnoth
5 years, 6 months ago (2015-06-22 20:04:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8799688d288c9acd71f0b4f193f9b1beac751aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698