Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 12025022: Add support for $ref'ing namespaces to server2. (Closed)

Created:
7 years, 11 months ago by not at google - send to devlin
Modified:
7 years, 11 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for $ref'ing namespaces to server2. R=jyasskin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178029

Patch Set 1 #

Total comments: 2

Patch Set 2 : precedence within namespaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/common/extensions/docs/server2/reference_resolver.py View 1 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/reference_resolver_test.py View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
7 years, 11 months ago (2013-01-18 18:08:21 UTC) #1
Jeffrey Yasskin
https://codereview.chromium.org/12025022/diff/1/chrome/common/extensions/docs/server2/reference_resolver.py File chrome/common/extensions/docs/server2/reference_resolver.py (right): https://codereview.chromium.org/12025022/diff/1/chrome/common/extensions/docs/server2/reference_resolver.py#newcode71 chrome/common/extensions/docs/server2/reference_resolver.py:71: if ref in api_list: Are the elements of api_list ...
7 years, 11 months ago (2013-01-18 18:27:31 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/12025022/diff/1/chrome/common/extensions/docs/server2/reference_resolver.py File chrome/common/extensions/docs/server2/reference_resolver.py (right): https://codereview.chromium.org/12025022/diff/1/chrome/common/extensions/docs/server2/reference_resolver.py#newcode71 chrome/common/extensions/docs/server2/reference_resolver.py:71: if ref in api_list: On 2013/01/18 18:27:31, Jeffrey Yasskin ...
7 years, 11 months ago (2013-01-18 18:30:25 UTC) #3
Jeffrey Yasskin
7 years, 11 months ago (2013-01-18 22:02:34 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698