Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5608)

Unified Diff: chrome/common/extensions/docs/server2/reference_resolver.py

Issue 12025022: Add support for $ref'ing namespaces to server2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: precedence within namespaces Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/reference_resolver_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/server2/reference_resolver.py
diff --git a/chrome/common/extensions/docs/server2/reference_resolver.py b/chrome/common/extensions/docs/server2/reference_resolver.py
index a9d6184bca394a9270cfb967fc313a63a3dfe0af..3fb77b1d66f30c61b63afe5b1fdbc8fd5fb1373a 100644
--- a/chrome/common/extensions/docs/server2/reference_resolver.py
+++ b/chrome/common/extensions/docs/server2/reference_resolver.py
@@ -67,6 +67,7 @@ class ReferenceResolver(object):
self._object_store = object_store
def _GetRefLink(self, ref, api_list, namespace, title):
+ # Check nodes within each API the ref might refer to.
parts = ref.split('.')
for i, part in enumerate(parts):
api_name = '.'.join(parts[:i])
@@ -104,6 +105,17 @@ class ReferenceResolver(object):
'text': title if title else text,
'name': node_name
}
+
+ # If it's not a reference to an API node it might just be a reference to an
+ # API. Check this last so that links within APIs take precedence over links
+ # to other APIs.
+ if ref in api_list:
+ return {
+ 'href': '%s.html' % ref,
+ 'text': title if title else ref,
+ 'name': ref
+ }
+
return None
def GetLink(self, ref, namespace=None, title=None):
« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/reference_resolver_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698