Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 12025005: Add help to landmines.py if it errors out with unexpected builder (Closed)

Created:
7 years, 11 months ago by scottmg
Modified:
7 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Visibility:
Public.

Description

Add help to landmines.py if it errors out with unexpected builder R=iannucci@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177534

Patch Set 1 #

Patch Set 2 : add value to message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/landmines.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
7 years, 11 months ago (2013-01-17 23:42:30 UTC) #1
iannucci
On 2013/01/17 23:42:30, scottmg wrote: Maybe for extra points, also print what it thinks GYP_GENERATORS ...
7 years, 11 months ago (2013-01-17 23:44:41 UTC) #2
iannucci
On 2013/01/17 23:44:41, iannucci wrote: > On 2013/01/17 23:42:30, scottmg wrote: > > Maybe for ...
7 years, 11 months ago (2013-01-17 23:46:49 UTC) #3
scottmg
Done
7 years, 11 months ago (2013-01-17 23:47:02 UTC) #4
iannucci
7 years, 11 months ago (2013-01-17 23:48:00 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698