build/landmines.py - Issue 12025005: Add help to landmines.py if it errors out with unexpected builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/landmines.py

Issue 12025005: Add help to landmines.py if it errors out with unexpected builder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add value to message Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/landmines.py

diff --git a/build/landmines.py b/build/landmines.py

index 4cd5722f33254962482851b6dc5e79031e3b9d3a..6c769e91a1aa514a0f2a3c1f48aa55659dec0e3b 100755

--- a/build/landmines.py

+++ b/build/landmines.py

@@ -168,7 +168,7 @@ def get_target_build_dir(build_tool, target, is_iphone=False):

elif build_tool == 'scons':

ret = os.path.join(SRC_DIR, 'sconsbuild', target)

else:

- raise NotImplementedError()

+ raise NotImplementedError('Unexpected GYP_GENERATORS (%s)' % build_tool)

return os.path.abspath(ret)

« no previous file with comments | « no previous file | no next file » | no next file with comments »