Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1202263006: [turbofan] Revive the useful parts of the SimplifiedOperatorReducer. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Revive the useful parts of the SimplifiedOperatorReducer. This partially reverts https://codereview.chromium.org/1162563002 because we might actually be able to optimize certain combinations now due to dead code elimination. R=titzer@chromium.org Committed: https://crrev.com/5056c8219aea58a49e500599c6ebdf5e291b9ef4 Cr-Commit-Position: refs/heads/master@{#29277}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reordered reducers. REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+575 lines, -17 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download
A + src/compiler/simplified-operator-reducer.h View 2 chunks +18 lines, -13 lines 0 comments Download
A src/compiler/simplified-operator-reducer.cc View 1 chunk +138 lines, -0 lines 0 comments Download
A test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +405 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-24 11:51:39 UTC) #1
Benedikt Meurer
Hey Ben, As discussed offline, this revives the unquestionable parts of the SimplifiedOperatorReducer. Mostly straight ...
5 years, 6 months ago (2015-06-24 11:52:40 UTC) #2
titzer
lgtm other than maybe an ordering issue. Thanks, that was fast! https://codereview.chromium.org/1202263006/diff/1/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): ...
5 years, 6 months ago (2015-06-24 12:37:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202263006/20001
5 years, 6 months ago (2015-06-25 04:05:46 UTC) #6
Benedikt Meurer
https://codereview.chromium.org/1202263006/diff/1/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/1202263006/diff/1/src/compiler/pipeline.cc#newcode608 src/compiler/pipeline.cc:608: AddReducer(data, &graph_reducer, &simple_reducer); On 2015/06/24 12:37:27, titzer wrote: > ...
5 years, 6 months ago (2015-06-25 04:05:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-25 04:47:11 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 04:47:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5056c8219aea58a49e500599c6ebdf5e291b9ef4
Cr-Commit-Position: refs/heads/master@{#29277}

Powered by Google App Engine
This is Rietveld 408576698