Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1162563002: [turbofan] Remove the useless SimplifiedOperatorReducer. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the useless SimplifiedOperatorReducer. The SimplifiedOperatorReducer is (mostly) unused, except for the very rough store elimination, and just eats compilation time. R=jarin@chromium.org Committed: https://crrev.com/19482d29e525ab939224ca9c24dba6e22be92da3 Cr-Commit-Position: refs/heads/master@{#28673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -643 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 4 chunks +0 lines, -7 lines 0 comments Download
D src/compiler/simplified-operator-reducer.h View 1 chunk +0 lines, -57 lines 0 comments Download
D src/compiler/simplified-operator-reducer.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +0 lines, -405 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-28 08:06:31 UTC) #1
Jarin
On 2015/05/28 08:06:31, Benedikt Meurer wrote: Assuming the constant propagation through changes is not necessary, ...
5 years, 7 months ago (2015-05-28 08:23:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162563002/1
5 years, 7 months ago (2015-05-28 08:36:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-28 08:38:08 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-28 08:38:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19482d29e525ab939224ca9c24dba6e22be92da3
Cr-Commit-Position: refs/heads/master@{#28673}

Powered by Google App Engine
This is Rietveld 408576698