Includes module header first.

Includes module header first.

This "include module header first" is part of the llvm style guide.

This change exposes "broken" headers that were accessing undefined types, or
even using types without forward declaring them.

BUG=
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=67f8de9adf6439881a00d8e0f081918436c71f62

[John, 2015-06-23 19:48:24]

jpp@chromium.org changed reviewers:
+ jvoung@chromium.org, kschimpf@google.com, stichnot@chromium.org

[Jim Stichnoth, 2015-06-23 23:05:04]

lgtm

https://codereview.chromium.org/1202253002/diff/1/src/IceBrowserCompileServer...
File src/IceBrowserCompileServer.cpp (right):

https://codereview.chromium.org/1202253002/diff/1/src/IceBrowserCompileServer...
src/IceBrowserCompileServer.cpp:20: #include <cstring>
I just became aware of http://llvm.org/docs/CodingStandards.html#include-style .
 What do you think about making Subzero conformant by moving all the
<system_includes> to the end?

https://codereview.chromium.org/1202253002/diff/1/src/IceClFlags.cpp
File src/IceClFlags.cpp (right):

https://codereview.chromium.org/1202253002/diff/1/src/IceClFlags.cpp#newcode20
src/IceClFlags.cpp:20: #include "IceClFlagsExtra.h"
If following http://llvm.org/docs/CodingStandards.html#include-style , then
would Ice*.h count as "Local/Private Headers" and come before llvm/*.h ?

https://codereview.chromium.org/1202253002/diff/1/src/IceConverter.cpp
File src/IceConverter.cpp (left):

https://codereview.chromium.org/1202253002/diff/1/src/IceConverter.cpp#oldcode14
src/IceConverter.cpp:14: #include <iostream>
cool, thanks!

[John, 2015-06-23 23:57:09]

Please take another look.

https://codereview.chromium.org/1202253002/diff/1/src/IceBrowserCompileServer...
File src/IceBrowserCompileServer.cpp (right):

https://codereview.chromium.org/1202253002/diff/1/src/IceBrowserCompileServer...
src/IceBrowserCompileServer.cpp:20: #include <cstring>
On 2015/06/23 23:05:04, stichnot wrote:
> I just became aware of http://llvm.org/docs/CodingStandards.html#include-style
.
>  What do you think about making Subzero conformant by moving all the
> <system_includes> to the end?

but that means goig through EVERY subzero file... :(

Oh, well, done. :)

https://codereview.chromium.org/1202253002/diff/1/src/IceClFlags.cpp
File src/IceClFlags.cpp (right):

https://codereview.chromium.org/1202253002/diff/1/src/IceClFlags.cpp#newcode20
src/IceClFlags.cpp:20: #include "IceClFlagsExtra.h"
On 2015/06/23 23:05:04, stichnot wrote:
> If following http://llvm.org/docs/CodingStandards.html#include-style , then
> would Ice*.h count as "Local/Private Headers" and come before llvm/*.h ?

I don't think so. I think a "private" header is a header that is "private" to
that particular module. For example, the IceTargetLoweringX8632.cpp includes the
private header "IceTargetLoweringX86Base.h"

[Jim Stichnoth, 2015-06-24 21:35:33]

lgtm

https://codereview.chromium.org/1202253002/diff/20001/src/IceBrowserCompileSe...
File src/IceBrowserCompileServer.h (right):

https://codereview.chromium.org/1202253002/diff/20001/src/IceBrowserCompileSe...
src/IceBrowserCompileServer.h:22: #include <atomic>
Separate each section with a blank line?

https://codereview.chromium.org/1202253002/diff/20001/src/IceRNG.cpp
File src/IceRNG.cpp (right):

https://codereview.chromium.org/1202253002/diff/20001/src/IceRNG.cpp#newcode21
src/IceRNG.cpp:21: const unsigned MAX = 2147483647;
constexpr if you feel like fixing this... (just caught my eye)

https://codereview.chromium.org/1202253002/diff/20001/src/IceRegAlloc.cpp
File src/IceRegAlloc.cpp (right):

https://codereview.chromium.org/1202253002/diff/20001/src/IceRegAlloc.cpp#new...
src/IceRegAlloc.cpp:30: const size_t REGS_SIZE = 32;
constexpr here too...

https://codereview.chromium.org/1202253002/diff/20001/src/IceTargetLoweringAR...
File src/IceTargetLoweringARM32.cpp (right):

https://codereview.chromium.org/1202253002/diff/20001/src/IceTargetLoweringAR...
src/IceTargetLoweringARM32.cpp:17: #include "llvm/Support/MathExtras.h"
Move this after Ice*.h includes?

[John, 2015-06-25 17:13:12]

As per lgtm, landing.

https://codereview.chromium.org/1202253002/diff/20001/src/IceBrowserCompileSe...
File src/IceBrowserCompileServer.h (right):

https://codereview.chromium.org/1202253002/diff/20001/src/IceBrowserCompileSe...
src/IceBrowserCompileServer.h:22: #include <atomic>
On 2015/06/24 21:35:33, stichnot wrote:
> Separate each section with a blank line?

Done.

https://codereview.chromium.org/1202253002/diff/20001/src/IceRNG.cpp
File src/IceRNG.cpp (right):

https://codereview.chromium.org/1202253002/diff/20001/src/IceRNG.cpp#newcode21
src/IceRNG.cpp:21: const unsigned MAX = 2147483647;
On 2015/06/24 21:35:33, stichnot wrote:
> constexpr if you feel like fixing this... (just caught my eye)

Done.

https://codereview.chromium.org/1202253002/diff/20001/src/IceRegAlloc.cpp
File src/IceRegAlloc.cpp (right):

https://codereview.chromium.org/1202253002/diff/20001/src/IceRegAlloc.cpp#new...
src/IceRegAlloc.cpp:30: const size_t REGS_SIZE = 32;
On 2015/06/24 21:35:33, stichnot wrote:
> constexpr here too...

Done.

https://codereview.chromium.org/1202253002/diff/20001/src/IceTargetLoweringAR...
File src/IceTargetLoweringARM32.cpp (right):

https://codereview.chromium.org/1202253002/diff/20001/src/IceTargetLoweringAR...
src/IceTargetLoweringARM32.cpp:17: #include "llvm/Support/MathExtras.h"
On 2015/06/24 21:35:33, stichnot wrote:
> Move this after Ice*.h includes?

Done.

[John, 2015-06-25 17:14:23]

Committed patchset #2 (id:20001) manually as
67f8de9adf6439881a00d8e0f081918436c71f62 (presubmit successful).