Includes module header first.

src/IceClFlags.cpp

 //===- subzero/src/IceClFlags.cpp - Command line flags and parsing --------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file defines commandline flags parsing.
 // This currently relies on llvm::cl to parse.  In the future, the minimal
 // build can have a simpler parser.
 //
 //===----------------------------------------------------------------------===//
 
+#include "IceClFlags.h"
+
 #include "llvm/Support/CommandLine.h"
 
-#include "IceClFlags.h"
 #include "IceClFlagsExtra.h"

[Jim Stichnoth, 2015/06/23 23:05:04]

If following http://llvm.org/docs/CodingStandards.html#include-style , then
would Ice*.h count as "Local/Private Headers" and come before llvm/*.h ?

[John, 2015/06/23 23:57:09]

I don't think so. I think a "private" header is a header that is "private" to
that particular module. For example, the IceTargetLoweringX8632.cpp includes the
private header "IceTargetLoweringX86Base.h"

 
 namespace cl = llvm::cl;
 
 // Options which are captured in Ice::ClFlags and propagated.
 
 namespace {
 
 cl::opt<bool> AllowErrorRecovery(
     "allow-pnacl-reader-error-recovery",
     cl::desc("Allow error recovery when reading PNaCl bitcode."),
@@ skipping 355 matching lines @@
   OutFlagsExtra.setGenerateBuildAtts(GenerateBuildAtts);
   OutFlagsExtra.setLLVMVerboseErrors(LLVMVerboseErrors);
   OutFlagsExtra.setAppName(AppName);
   OutFlagsExtra.setInputFileFormat(InputFileFormat);
   OutFlagsExtra.setIRFilename(IRFilename);
   OutFlagsExtra.setLogFilename(LogFilename);
   OutFlagsExtra.setOutputFilename(OutputFilename);
 }
 
 } // end of namespace Ice