Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1202013002: Update some Sk4px APIs. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update some Sk4px APIs. Mostly this is about ergonomics, making it easier to do good operations and hard / impossible to do bad ones. - SkAlpha / SkPMColor constructors become static factories. - Remove div255TruncNarrow(), rename div255RoundNarrow() to div255(). In practice we always want to round, and the narrowing to 8-bit is contextually obvious. - Rename fastMulDiv255Round() approxMulDiv255() to stress it's approximate-ness over its speed. Drop Round for the same reason as above... we should always round. - Add operator overloads so we don't have to keep throwing in seemingly-random Sk4px() or Sk4px::Wide() casts. - use operator*() for 8-bit x 8-bit -> 16-bit math. It's always what we want, and there's generally no 8x8->8 alternative. - MapFoo can take a const Func&. Don't think it makes a big difference, but nice to do. BUG=skia: Committed: https://skia.googlesource.com/skia/+/059ac00446404506a46cd303db15239c7aae49d5

Patch Set 1 #

Patch Set 2 : fix none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -107 lines) Patch
M src/core/Sk4px.h View 5 chunks +63 lines, -56 lines 0 comments Download
M src/core/Sk4pxXfermode.h View 3 chunks +17 lines, -30 lines 0 comments Download
M src/core/SkBlitRow_D32.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/opts/Sk4px_NEON.h View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/Sk4px_SSE2.h View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/Sk4px_none.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/SkNxTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202013002/1
5 years, 6 months ago (2015-06-22 17:12:46 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/880)
5 years, 6 months ago (2015-06-22 17:14:01 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202013002/20001
5 years, 6 months ago (2015-06-22 17:15:21 UTC) #6
mtklein
lgtm
5 years, 6 months ago (2015-06-22 17:23:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202013002/20001
5 years, 6 months ago (2015-06-22 17:24:13 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 17:39:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/059ac00446404506a46cd303db15239c7aae49d5

Powered by Google App Engine
This is Rietveld 408576698