Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1201983006: Clean up usage of SkSurfaceProps (Closed)

Created:
5 years, 6 months ago by robertphillips
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up usage of SkSurfaceProps This CL continues cleaning up Skia's usage of SkSurfaceProps. It: Removes the duplicate SkSurfaceProps object from SkImageFilter::Proxy. Removes a dispreferred ctor from SkCanvas Removes the initForRootLayer entry point from SkDevice (since the root device and the canvas should always have the same pixel geometry now). Committed: https://skia.googlesource.com/skia/+/efbffedd68636e94d4379e84a2585bce80f6fb8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -76 lines) Patch
M include/core/SkCanvas.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +5 lines, -9 lines 0 comments Download
M include/core/SkSurfaceProps.h View 1 chunk +0 lines, -3 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 4 chunks +4 lines, -14 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 4 chunks +11 lines, -18 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 8 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
robertphillips
5 years, 6 months ago (2015-06-22 18:26:15 UTC) #3
reed1
lgtm
5 years, 6 months ago (2015-06-22 18:29:03 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201983006/1
5 years, 6 months ago (2015-06-22 18:38:39 UTC) #6
Stephen White
LGTM. Code goes away 👍
5 years, 6 months ago (2015-06-22 18:40:17 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-22 18:45:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201983006/1
5 years, 6 months ago (2015-06-22 19:05:21 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 19:06:12 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/efbffedd68636e94d4379e84a2585bce80f6fb8f

Powered by Google App Engine
This is Rietveld 408576698