Move LayoutTest Linux distribution detection to PlatformInfo

Move LayoutTest Linux distribution detection to PlatformInfo

Also introduce a custom Apache configuration for Arch Linux, which differs
slightly from the Debian configuration.

BUG=502972
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197714

[ingemara, 2015-06-22 08:32:51]

ingemara@opera.com changed reviewers:
+ dpranke@chromium.org, ojan@chromium.org

[ingemara, 2015-06-22 08:38:35]

PTAL, and please suggest any reviewers if needed.

[Dirk Pranke, 2015-06-22 22:58:05]

This mostly looks fine; I have some comments about moving tests closer to the
code under test.

https://codereview.chromium.org/1201873002/diff/20001/Tools/Scripts/webkitpy/...
File Tools/Scripts/webkitpy/layout_tests/port/base.py (right):

https://codereview.chromium.org/1201873002/diff/20001/Tools/Scripts/webkitpy/...
Tools/Scripts/webkitpy/layout_tests/port/base.py:1468: # All platforms use
apache2 except for CYGWIN (and Mac OS X Tiger and prior, which we no longer
support).
Can you delete line 1468 while you're at it; we don't support cygwin or tiger,
so this is at best confusing.

https://codereview.chromium.org/1201873002/diff/20001/Tools/Scripts/webkitpy/...
File Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py (right):

https://codereview.chromium.org/1201873002/diff/20001/Tools/Scripts/webkitpy/...
Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:427:
self.assertEqual(port._apache_config_file_name_for_platform(), config_file)
These tests will be run on every test case for every port; perhaps they should
be moved to unittests for PlatformInfo instead, now that the implementation code
is not in port/base.py ?

[ingemara, 2015-06-23 09:03:21]

On 2015/06/22 22:58:05, Dirk Pranke wrote:
>
https://codereview.chromium.org/1201873002/diff/20001/Tools/Scripts/webkitpy/...
> Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:427:
> self.assertEqual(port._apache_config_file_name_for_platform(), config_file)
> These tests will be run on every test case for every port; perhaps they should
> be moved to unittests for PlatformInfo instead, now that the implementation
code
> is not in port/base.py ?

The test "helper" tests the _apache_config_file_name_for_platform method, which
is still implemented in port/base.py. The only code that moved is how we detect
which distribution we're running. Those tests moved as well, but I think we
still want to keep this test here. Or did I misunderstand your comment?

[Dirk Pranke, 2015-06-23 19:13:17]

On 2015/06/23 09:03:21, ingemara wrote:
> On 2015/06/22 22:58:05, Dirk Pranke wrote:
> >
>
https://codereview.chromium.org/1201873002/diff/20001/Tools/Scripts/webkitpy/...
> > Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:427:
> > self.assertEqual(port._apache_config_file_name_for_platform(), config_file)
> > These tests will be run on every test case for every port; perhaps they
should
> > be moved to unittests for PlatformInfo instead, now that the implementation
> code
> > is not in port/base.py ?
> 
> The test "helper" tests the _apache_config_file_name_for_platform method,
which
> is still implemented in port/base.py. The only code that moved is how we
detect
> which distribution we're running. Those tests moved as well, but I think we
> still want to keep this test here. Or did I misunderstand your comment?

Fair enough. It seems a bit silly to test the linux distros and config files for
non-linux ports.

I suppose we could move at least some of these tests into linux_unittest.py, but
it's probably not worth it.

[Dirk Pranke, 2015-06-23 19:13:38]

lgtm.

[ingemara, 2015-06-24 07:09:41]

The CQ bit was checked by ingemara@opera.com

[commit-bot: I haz the power, 2015-06-24 07:09:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1201873002/40001

[commit-bot: I haz the power, 2015-06-24 08:20:50]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197714