Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1788)

Unified Diff: Tools/Scripts/webkitpy/common/system/platforminfo_mock.py

Issue 1201873002: Move LayoutTest Linux distribution detection to PlatformInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove crusty comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/common/system/platforminfo_mock.py
diff --git a/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py b/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py
index 1ba00190b9fbc917b3c206102dcbe61801ba734a..f51ea545dd13890874f54b5cd53f88c6949dd35c 100644
--- a/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py
+++ b/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py
@@ -28,9 +28,10 @@
class MockPlatformInfo(object):
- def __init__(self, os_name='mac', os_version='snowleopard', is_highdpi=False):
+ def __init__(self, os_name='mac', os_version='snowleopard', linux_distribution=None, is_highdpi=False):
self.os_name = os_name
self.os_version = os_version
+ self._linux_distribution = linux_distribution
self._is_highdpi = is_highdpi
def is_mac(self):
@@ -54,6 +55,9 @@ class MockPlatformInfo(object):
def display_name(self):
return "MockPlatform 1.0"
+ def linux_distribution(self):
+ return self._linux_distribution if self.is_linux() else None
+
def total_bytes_memory(self):
return 3 * 1024 * 1024 * 1024 # 3GB is a reasonable amount of ram to mock.
« no previous file with comments | « Tools/Scripts/webkitpy/common/system/platforminfo.py ('k') | Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698