Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1201773005: Use CHECK_LT in CheckHandleCountVisitor for better error message (Closed)

Created:
5 years, 6 months ago by adamk
Modified:
5 years, 6 months ago
CC:
v8-dev, Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use CHECK_LT in CheckHandleCountVisitor for better error message Committed: https://crrev.com/97a887c530da3252d85ab666b125d9ff0faed790 Cr-Commit-Position: refs/heads/master@{#29203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 6 months ago (2015-06-22 18:37:37 UTC) #2
arv (Not doing code reviews)
lgtm
5 years, 6 months ago (2015-06-22 18:56:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201773005/1
5 years, 6 months ago (2015-06-22 18:56:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 19:18:35 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 19:18:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97a887c530da3252d85ab666b125d9ff0faed790
Cr-Commit-Position: refs/heads/master@{#29203}

Powered by Google App Engine
This is Rietveld 408576698