Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: src/heap/heap.cc

Issue 1201773005: Use CHECK_LT in CheckHandleCountVisitor for better error message (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index dbe7cc27b8d3f93df974e008c71847d9dd3c50db..df1ba3129f859c61163561df1e709de6d1b2dd4a 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -5977,7 +5977,7 @@ void Heap::PrintHandles() {
class CheckHandleCountVisitor : public ObjectVisitor {
public:
CheckHandleCountVisitor() : handle_count_(0) {}
- ~CheckHandleCountVisitor() { CHECK(handle_count_ < 2000); }
+ ~CheckHandleCountVisitor() { CHECK_LT(handle_count_, 2000); }
void VisitPointers(Object** start, Object** end) {
handle_count_ += end - start;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698