drive: Add support for pagenation to FakeDriveService

drive: Add support for pagenation to FakeDriveService

Add support for start-offset (only used in FakeDriveService)
and max-results parameters which implement pagination.

BUG=162350
TEST=none; test changes


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178271

[satorux1, 2013-01-18 22:45:31]

I've been keeping this patch for a while. Finally I had some time to polish. :)

[kinaba, 2013-01-19 03:28:18]

The patch description looks outdated.
search feature is already landed, and this one contains only the "along the way"
part.

https://codereview.chromium.org/12017026/diff/9001/chrome/browser/google_apis...
File chrome/browser/google_apis/fake_drive_service.cc (right):

https://codereview.chromium.org/12017026/diff/9001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service.cc:153: int start_index = 0;
The usage of "start-index" url parameter looks diffent from
the real server. Is it intentional?

For the real server and the GDataWAPIService, start_index is the very parameter
where |start_changestamp| is passed to the server (see
GDataWapiUrlGenerator::AddFeedUrlParams), not the offset from start_changestamp.

Currently we are ignoring start_changestamp if the URL is already set.
For example,
GDataWAPIService::GetResourceList(GURL("http://url/?start-index=100", 23 , 0, 0)
will return
the entries from the 100th one, not 123rd one.

[kinaba, 2013-01-19 03:43:47]

Ah, looking at the another patch you posted, I've changed my mind.

To support the pagenated search feed (that has nothing to do with the
changestamps),
the current implementation looks reasonable. Please forget my previous comment.

I'm still anxious about using the name "start-index" with the different
semantics
than the real service. You might want to use a different name.

[satorux1, 2013-01-22 17:44:09]

https://codereview.chromium.org/12017026/diff/9001/chrome/browser/google_apis...
File chrome/browser/google_apis/fake_drive_service.cc (right):

https://codereview.chromium.org/12017026/diff/9001/chrome/browser/google_apis...
chrome/browser/google_apis/fake_drive_service.cc:153: int start_index = 0;
On 2013/01/19 03:28:18, kinaba wrote:
> The usage of "start-index" url parameter looks diffent from
> the real server. Is it intentional?
> 
> For the real server and the GDataWAPIService, start_index is the very
parameter
> where |start_changestamp| is passed to the server (see
> GDataWapiUrlGenerator::AddFeedUrlParams), not the offset from
start_changestamp.
> 
> Currently we are ignoring start_changestamp if the URL is already set.
> For example,
> GDataWAPIService::GetResourceList(GURL("http://url/?start-index=100", 23 , 0,
0)
> will return
> the entries from the 100th one, not 123rd one.

That's a great catch! I wasn't aware of this incompatibility of the semantics.
Renamed this to start-offset. Added some comment too.

[kinaba, 2013-01-22 23:23:29]

lgtm. thanks!

[commit-bot: I haz the power, 2013-01-23 06:12:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/12017026/19001

[commit-bot: I haz the power, 2013-01-23 08:27:14]

Change committed as 178271